Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create CODEOWNERS #3

Merged
merged 1 commit into from
Jun 14, 2024
Merged

chore: create CODEOWNERS #3

merged 1 commit into from
Jun 14, 2024

Conversation

cedoor
Copy link
Member

@cedoor cedoor commented Jun 14, 2024

Description

The CODEOWNERS file defines individuals or teams that are responsible for code in a repository. Code owners are automatically requested for review when someone opens a pull request that modifies code that they own.

As a general rule, at least 1 review by one of the code owners in new PRs is always required.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run yarn test without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@cedoor cedoor requested review from signorecello and sripwoud June 14, 2024 12:32
@signorecello signorecello merged commit 4746163 into main Jun 14, 2024
1 check passed
@signorecello signorecello deleted the chore/codeowners branch June 14, 2024 23:07
Copy link
Member

@sripwoud sripwoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

post merge ACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants