chore: format all files (incl .nr)

[sripwoud]

Closes #2

This PR:

• sets up dprint to format all files
• format all files
• modifies the tests workflow
  • renames it to main
  • includes a style check
  • removes the node install and deps install in the tests job

[signorecello]

Thanks! This looks slick! When I have some time, I'll remove nargo altogether since we can use bb.js directly to fetch the solidity verifier, so pretty much everything can go in hardhat tasks or node scripts

[sripwoud]

Oh I didn't know about bb.js.
Do you mean in this case it is not useful to have this merkle_trees Noir package anymore?
It is basically the whole content of this repo.

[sripwoud]

@signorecello should we merge this nonetheless?

[signorecello]

It's definitely still useful, as BB.JS is just a TS interface to Barretenberg (which is C++ compiled to WASM). It doesn't provide any Noir circuits, it doesn't understand Noir at all hehe.

As for the nargofmt command, I checked with the team and apparently it was done by a grantee some time ago, before we had impl and traits, but there's no availability from the team to open this pandora's box now. Could be tackled by another grantee I suppose!

In any case using rustfmt seems like a great workaround. Let's merge it 😈

[cedoor]

@sripwoud @signorecello
OT: I wonder if we should use Node in this repo. Is it worth it? Or is it better a Rust env?

[sripwoud]

@sripwoud @signorecello OT: I wonder if we should use Node in this repo. Is it worth it? Or is it better a Rust env?

based on the docs, deps with noir are rather managed with git urls "a la rust".
See
https://noir-lang.org/docs/noir/modules_packages_crates/dependencies/#specifying-a-dependency

So using node sounds useless to me here. Should I make this change in this PR or separately?

[cedoor]

So using node sounds useless to me here.

I agree, removing Node means some tools will not be supported anymore tho (e.g. czg, changelogithub), but that's fine..

Should I make this change in this PR or separately?

Maybe a new PR would be better!

[sripwoud]

I agree, removing Node means some tools will not be supported anymore tho (e.g. czg, changelogithub), but that's fine..

oh right
I rather meant have packages/merkle_trees node-free. But it is already 😅

If the node dev deps are only at the root level it is fine imo actually.
Otherwise we ll need to find an alternative to make sure all this is setup (linting commits etc...)

[cedoor]

@sripwoud

If the node dev deps are only at the root level it is fine imo actually.

The question is, are devs who use Noir more familiar with Rust or Node?