Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(merkle-trees): pin compiler_version #6

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Conversation

sripwoud
Copy link
Member

@sripwoud sripwoud commented Jun 28, 2024

nargo version is already pinned in the GH action workflow (see privacy-scaling-explorations/zk-kit#256).
But not in the Nargo.toml.

With the latest version (that I was using) the tests will fail because of breaking changes in the std lib:
ex

error: Could not resolve 'HashPath' in path
   ┌─ /home/sripwoud/code/zk-kit/zk-kit.noir/packages/merkle-trees/src/merkle.nr:25:22
   │
25 │ impl Modifier<Field, HashPath> for MerkleTree {
   │                      --------
   │

error: cannot find `pedersen_hash_slice` in this scope
  ┌─ /home/sripwoud/code/zk-kit/zk-kit.noir/packages/merkle-trees/src/merkle/tests/pedersen.nr:5:5
  │
5 │     pedersen_hash_slice(leaves)
  │     ------------------- not found in this scope

@sripwoud sripwoud requested a review from signorecello as a code owner June 28, 2024 08:54
@sripwoud sripwoud added the bug 🐛 Something isn't working label Jun 28, 2024
Copy link
Collaborator

@signorecello signorecello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, yes best to pin versions

@signorecello signorecello merged commit 66bcda8 into main Jun 28, 2024
1 check passed
@signorecello signorecello deleted the chore/pin-noir branch June 28, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants