Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(imt): define export type IMTNode instead of any #366

Merged

Conversation

0x471
Copy link
Contributor

@0x471 0x471 commented Jan 16, 2025

Description

Changed IMTNode type from any to number | string | bigint to make it clearer.

Related Issue(s)

Fixes #339

Other information

Checklist

  • I have read and understand the contributor guidelines and code of conduct.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run yarn style without getting any errors
  • [] I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Important

We do not accept minor grammatical fixes (e.g., correcting typos, rewording sentences) unless they significantly improve clarity in technical documentation. These contributions, while appreciated, are not a priority for merging. If there is a grammatical mistake, please feel free to message the team.

@0x471 0x471 requested a review from cedoor as a code owner January 16, 2025 13:06
@cedoor cedoor merged commit 34c781c into privacy-scaling-explorations:main Jan 17, 2025
2 checks passed
Copy link

gitpoap-bot bot commented Jan 17, 2025

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2025 ZK-KIT Contributor:

GitPOAP: 2025 ZK-KIT Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

define export type IMTNode = number | string | bigint; directly istead of any.
2 participants