Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change link to icon on DNS provider table #2457

Merged
merged 1 commit into from
Mar 31, 2024
Merged

Change link to icon on DNS provider table #2457

merged 1 commit into from
Mar 31, 2024

Conversation

dngray
Copy link
Member

@dngray dngray commented Mar 30, 2024 •
edited
Loading

Changes proposed in this PR:

@jonaharagon should we have used icons here or reference numbers? I wonder which looks better.

  • I have disclosed any relevant conflicts of interest in my post.
  • I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project.
  • I am the sole author of this work.
  • I agree to the Community Code of Conduct.

dngray added a commit that referenced this pull request Mar 30, 2024
@dngray
Change item to icon (#2457)
9d40ffb
@netlify Netlify
Copy link

netlify bot commented Mar 30, 2024 •
edited
Loading

✅ Deploy Preview for privacyguides ready!

Name Link
🔨 Latest commit 393d30a
🔍 Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/6607e34d76200c0008eeb7ae
😎 Deploy Preview https://deploy-preview-2457.preview.privacyguides.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 4 paths audited
Performance: 71 (🔴 down 5 from production)
Accessibility: 91 (🔴 down 1 from production)
Best Practices: 81 (🔴 down 17 from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 30, 2024 •
edited
Loading

This is a test 👀 https://9d40ffbe891a--glowing-salamander-8d7127.netlify.app/

@dngray dngray requested a review from jonaharagon March 30, 2024 10:07
@dngray dngray added the c:enhancements new features or other enhancements to the website itself label Mar 30, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 30, 2024 •
edited
Loading

✅ Deploy Preview for privacyguides ready!

Name Link
🔨 Latest commit 9a56bd4
🔍 Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/6608dd2a387d830008f8238c
😎 Deploy Preview https://deploy-preview-2457.preview.privacyguides.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 4 paths audited
Performance: 74 (🔴 down 2 from production)
Accessibility: 91 (🔴 down 1 from production)
Best Practices: 81 (🔴 down 17 from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@dngray dngray changed the title Change item to icon Change item to icon on DNS table Mar 30, 2024
dngray added a commit that referenced this pull request Mar 31, 2024
@dngray
Change item to icon (#2457)
896e101
@dngray dngray added c:providers service providers and similar centralized/federated services t:bug website bugs or errors and removed c:enhancements new features or other enhancements to the website itself labels Mar 31, 2024
@dngray dngray changed the title Change item to icon on DNS table Change link to icon on DNS provider table Mar 31, 2024
dngray added a commit that referenced this pull request Mar 31, 2024
@dngray
Change link to icon on DNS provider table (#2457)
0edff29
@dngray dngray merged commit 9a56bd4 into main Mar 31, 2024
6 of 7 checks passed
@dngray dngray deleted the pr-dns_signed_profile branch March 31, 2024 03:49
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/2024-03-31/17602/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaharagon jonaharagon jonaharagon approved these changes

Assignees
No one assigned
Labels
c:providers service providers and similar centralized/federated services t:bug website bugs or errors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dngray @privacyguides-bot @jonaharagon