Revert "Ente Auth desktop apps on all platforms (#2453)" #2458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jonaharagon
commented
Mar 30, 2024
jonaharagon
commented
- Reverts 6aa14e8 and hopefully we can address Ente Auth has now desktop apps available for all platforms #2453 (comment) this time around! 🤨
✅ Deploy Preview for privacyguides ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jonaharagon
commented
Mar 31, 2024
| - [:simple-windows11: Windows](https://ente.io/download) | ||
| - [:simple-apple: macOS](https://ente.io/download) | ||
| - [:simple-linux: Linux](https://ente.io/download) | ||
| - [:simple-github: GitHub](https://github.com/ente-io/ente/releases) | ||
| - [:simple-github: GitHub](https://github.com/ente-io/ente/releases?q=auth) |
There was a problem hiding this comment.
upon additional thought, I don't want to link to Windows/macOS/Linux downloads here in the first place, given that:
- we already link to github releases
- we don't recommend desktop totp apps anyways (see line 104 on page)
There was a problem hiding this comment.
Fair enough, we might have too hastily merged this.
dngray
approved these changes
Mar 31, 2024
This reverts commit 6aa14e8. Signed-off-by: Daniel Gray <[email protected]>
dngray
approved these changes
Mar 31, 2024
dngray
force-pushed
the
jonaharagon/revert-2453
branch
from
a2d287c
to
9169afa
Compare
dngray
added
c:software
|
This pull request has been mentioned on Privacy Guides. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.