Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: Remove Brave's IPFS mentions and add separate iOS configs #2780

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

update: Remove Brave's IPFS mentions and add separate iOS configs #2780

wants to merge 12 commits into from
+75 −38

Conversation

redoomed1
Copy link
Member

@redoomed1 redoomed1 commented Oct 19, 2024 •
edited
Loading

List of changes proposed in this PR:

  • Remove recommendation to disable IPFS functionality in Brave's desktop and mobile apps
  • Use content tabs to cleanly separate settings for the Android and iOS versions of Brave
    • This makes sure that the discerning reader using iOS isn't glossing over settings that do not apply to the version of Brave on their device.
  • Add annotation which mentions that the Leo setting is only for Brave's Android app.

@redoomed1
update: Remove IPFS instruction in recommended Brave configs
eea359a 
Other changes:

- Apply consistent formatting
- Remove empty heading

Signed-off-by: redoomed1 <[email protected]>
@redoomed1
update: Remove IPFS instruction in recommended Brave configs
cb28a7b 
Other changes:

- Note how some settings appear only on one mobile platform and not on the other
- Fuse two Shields subheadings into one
- Apply consistent formatting

Signed-off-by: redoomed1 <[email protected]>
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides Community. There might be relevant details there:

https://discuss.privacyguides.net/t/brave-ipfs-gateway-not-in-brave-browser/20895/4

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 19, 2024 •
edited
Loading

✅ Your preview is ready!

Name Link
🔨 Latest commit 43ee8bb
😎 Preview https://2780--glowing-salamander-8d7127.netlify.app/

@redoomed1 redoomed1 added the c:browsers browsers, add-ons, and related topics label Oct 19, 2024
@redoomed1
fix: Icon
24f6509 
Signed-off-by: redoomed1 <[email protected]>
@redoomed1 redoomed1 added the t:correction content corrections or errors label Oct 19, 2024
@redoomed1 redoomed1 marked this pull request as draft October 19, 2024 21:19
@redoomed1
style: Test content tabs for platform-specific settings
aa4e1d4 
Signed-off-by: redoomed1 <[email protected]>
@redoomed1
fix: Content tab syntax
082ab36 
Signed-off-by: redoomed1 <[email protected]>
@redoomed1
fix: Content tab syntax and test nested admonition
b74ba9a 
Signed-off-by: redoomed1 <[email protected]>
@redoomed1
fix: Embedded annotation syntax and fill in Android tab
91f2c44 
Signed-off-by: redoomed1 <[email protected]>
@redoomed1
fix: Annotation syntax
36ac591 
Signed-off-by: redoomed1 <[email protected]>
@redoomed1
feat: Complete content tabs for platform-specific settings
e9bd3d6 
Signed-off-by: redoomed1 <[email protected]>
@redoomed1
update: Refine iOS-specific instructions on sticking to default lists
550c45d 
Signed-off-by: redoomed1 <[email protected]>
@redoomed1
style: Increase level for Android-specific headings
43ee8bb 
Signed-off-by: redoomed1 <[email protected]>
@redoomed1 redoomed1 marked this pull request as ready for review October 19, 2024 23:01
@redoomed1 redoomed1 changed the title update: Remove Brave's IPFS mentions and note platform-specific settings update: Remove Brave's IPFS mentions and add separate iOS configs Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimg45 kimg45 kimg45 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
c:browsers browsers, add-ons, and related topics t:correction content corrections or errors
Projects
PR Review Status
Status: Unreviewed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@redoomed1 @privacyguides-bot @kimg45