Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multithreaded Decryption #1490

Closed

Conversation

tyurek
Copy link
Collaborator

@tyurek tyurek commented Dec 12, 2024

Adds a seq_join and async_move to the shard code operating on encrypted report streams to make decryption parallelizable.

To make sure it is in fact running in multiple cores, I added a print line to the lambda that calls the decrypt function and tested with the multi-threading feature
cargo test --package ipa-core --test hybrid --no-default-features --features "cli compact-gate web-app real-world-infra test-fixture relaxed-dp multi-threading" -- test_hybrid --exact
Example output:

thread id: Thread { id: ThreadId(12), name: Some("query-executor"), .. }
thread id: Thread { id: ThreadId(8), name: Some("query-executor"), .. }
thread id: Thread { id: ThreadId(8), name: Some("query-executor"), .. }
thread id: Thread { id: ThreadId(9), name: Some("query-executor"), .. }
thread id: Thread { id: ThreadId(12), name: Some("query-executor"), .. }
thread id: Thread { id: ThreadId(12), name: Some("query-executor"), .. }
thread id: Thread { id: ThreadId(8), name: Some("query-executor"), .. }

@tyurek tyurek closed this Dec 12, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 95.81152% with 8 lines in your changes missing coverage. Please review.

Project coverage is 93.08%. Comparing base (ff37b8a) to head (8496b46).

Files with missing lines Patch % Lines
ipa-core/src/report/hybrid.rs 91.01% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1490      +/-   ##
==========================================
+ Coverage   93.06%   93.08%   +0.01%     
==========================================
  Files         239      237       -2     
  Lines       43546    43605      +59     
==========================================
+ Hits        40526    40588      +62     
+ Misses       3020     3017       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant