Skip to content

Commit

Permalink
chore(UI): Remove dead code realted to the CrossValidation widget (#1276
Browse files Browse the repository at this point in the history
)

Follow up from #1265
  • Loading branch information
rouk1 authored Jan 31, 2025
1 parent 066e14b commit 0147194
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 863 deletions.
7 changes: 0 additions & 7 deletions skore-ui/src/components/MediaWidgetSelector.vue
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,4 @@ function matchMediaType(mediaType: string) {
:src="props.item.data"
/>
<HtmlSnippetWidget v-if="matchMediaType('text/html')" :src="props.item.data" />
<CrossValidationReport
v-if="matchMediaType('application/vnd.skore.cross_validation')"
:scalar-results="props.item.data.scalar_results"
:tabular-results="props.item.data.tabular_results"
:plots="props.item.data.plots"
:sections="props.item.data.sections"
/>
</template>
43 changes: 0 additions & 43 deletions skore-ui/src/components/MetricFavorability.vue

This file was deleted.

40 changes: 0 additions & 40 deletions skore-ui/src/dto.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,43 +31,3 @@ export interface ProjectDto {
* Sorted from newest to oldest.
*/
export type ActivityFeedDto = ProjectItemDto[];

export type Favorability = "greater_is_better" | "lower_is_better" | "unknown";

export interface ScalarResultDto {
name: string;
value: number;
stddev?: number;
label?: string;
description?: string;
favorability: Favorability;
}

export interface TabularResultDto {
name: string;
columns: any[];
data: any[][];
favorability: Favorability[];
}

export interface PrimaryResultsDto {
scalarResults: ScalarResultDto[];
tabularResults: TabularResultDto[];
}

export interface PlotDto {
name: string;
value: any;
}

export interface DetailSectionItemDto {
name: string;
description: string;
value: string;
}

export interface DetailSectionDto {
title: string;
icon: string;
items: DetailSectionItemDto[];
}
Loading

0 comments on commit 0147194

Please sign in to comment.