-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle canceled / forfeited games #309
Handle canceled / forfeited games #309
Conversation
@probberechts please let me know if these changes sit well with you. I'm open to any feedback so we can fix this issue once and for all |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #309 +/- ##
==========================================
+ Coverage 61.28% 61.43% +0.15%
==========================================
Files 10 10
Lines 1431 1434 +3
Branches 290 292 +2
==========================================
+ Hits 877 881 +4
Misses 508 508
+ Partials 46 45 -1
☔ View full report in Codecov by Sentry. |
…atch regardless of the order of matches
_concat would throw an error when analysing Tottenham-Rennes, as the game was forfeited and, therefore, there is no match data available for it. The dataframe resulting from this page had fewer columns than the ones for other games in the competition, thus throwing an error.
This is a new attempt to solve #304.