Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle canceled / forfeited games #309

Merged
merged 8 commits into from
Jul 27, 2023
Merged

Handle canceled / forfeited games #309

merged 8 commits into from
Jul 27, 2023

Conversation

lorenzodb1
Copy link
Contributor

@lorenzodb1 lorenzodb1 commented Jul 27, 2023

_concat would throw an error when analysing Tottenham-Rennes, as the game was forfeited and, therefore, there is no match data available for it. The dataframe resulting from this page had fewer columns than the ones for other games in the competition, thus throwing an error.

This is a new attempt to solve #304.

@lorenzodb1 lorenzodb1 marked this pull request as ready for review July 27, 2023 07:50
@lorenzodb1
Copy link
Contributor Author

@probberechts please let me know if these changes sit well with you. I'm open to any feedback so we can fix this issue once and for all

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.15% 🎉

Comparison is base (d5043e6) 61.28% compared to head (7aa1446) 61.43%.
Report is 1 commits behind head on master.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #309      +/-   ##
==========================================
+ Coverage   61.28%   61.43%   +0.15%     
==========================================
  Files          10       10              
  Lines        1431     1434       +3     
  Branches      290      292       +2     
==========================================
+ Hits          877      881       +4     
  Misses        508      508              
+ Partials       46       45       -1     
Files Changed Coverage Δ
soccerdata/fbref.py 86.25% <100.00%> (+0.31%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

soccerdata/fbref.py Outdated Show resolved Hide resolved
tests/test_FBref.py Outdated Show resolved Hide resolved
soccerdata/fbref.py Show resolved Hide resolved
@probberechts probberechts added bug Something isn't working FBref Issue or pull request related to the FBref scraper labels Jul 27, 2023
@probberechts probberechts merged commit 526dda0 into probberechts:master Jul 27, 2023
10 checks passed
@lorenzodb1 lorenzodb1 deleted the lorenzodb1_fix_tottenham_concat_bug branch July 27, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working FBref Issue or pull request related to the FBref scraper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants