Fix Device Master Volume Control handling #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ump messages, and fix issue probonopd#773 - Device Master Volume Control handling.
…isn't very responsive, so switched to print to stderr which flushes buffer immediately.
|
Build for testing: |
|
@RichyT can you please test the build above and let us know whether it fixes the issue for you? Thanks. |
|
Build for testing: |
|
Sorry, no sound at all with that one. Verified that I changed the output to hdmi too. On that note, there does seem to be at least one power-up sequence that sometimes leads to no sound (I may file another bug report for that) but I tried multiple and nothing. Edit: Hold that thought. I rolled back to the previous version and still no sound. I'll have to dig into it some more. |
|
OK, turns out the usbspeed thing was needed. Works good now, including full volume control while playing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And also comment out low-level MIDI dump code that really should only be there if someone is messing around with the MIDI handler itself.
-- actually no, that is already commented out in the serial driver. But this is very unresponsive due to line-buffer flushing, etc, so switched to fprintf to stderr instead.
This is a fix for Issue #773 and partly fixes #502 - at least the Master Volume Control part - the message is now explicitly checking all SysEx bytes and the message length to ensure it really is a MIDI SysEx realtime device control message for the Master Volume Control.
Kevin