Fx full by @jnonis

[probonopd]

No description provided.

[github-actions]

Build for testing:
MiniDexed_2025-01-12-6e89ab4
Use at your own risk.

[probonopd]

Working well so far on my Raspberry Pi Zero 2 W. 000118_TX816 EP FX.zip plays well for me with no crackle.

Here we have

• For each TG: 1 MIDI FX and 1 Insert FX
• Globally: 2 Send FX and 1 Master FX

[github-actions]

Build for testing:
MiniDexed_2025-01-12-7175505
Use at your own risk.

[Banana71]

Build for testing:
MiniDexed_2025-01-12-7175505

Testet with my Raspberry Pi 3 Model A+

• If I set the sample rate to 22000Hz the sound output works reliably.
• The SSD1306 display seems slower, the display is no longer built up as quickly
• The "Save as default" command does not work correctly. The first performance of the current bank is overwritten. (Probably a bug that applies to all versions)
• The sample rate set in the minidexed.ini affects the reverb time of the standard Reverb effect. Higher sample rates mean shorter reverb times and correspondingly lower sample rates mean longer reverb times.
• The DAC crashes during many performances. When loading a performance, there is a loud cracking sound and the audio output can only be revived by restarting. I have not yet found a common cause for this.

[probonopd]

Thanks for your testing @Banana71, this is really a big help.

If I set the sample rate to 22000Hz the sound output works reliably.

So far I have not tested other sample rates. Do you know sample rates that work with the normal build but not with this one?

The SSD1306 display seems slower, the display is no longer built up as quickly

I noted the same with a 16x2 character display. I wonder what additional processing is going on even when no sound is playing?

The "Save as default" command does not work correctly. The first performance of the current bank is overwritten. (Probably a bug that applies to all versions)

Can you please retest this with the normal version and open a bug if it is there too?

The sample rate set in the minidexed.ini affects the reverb time of the standard Reverb effect. Higher sample rates mean shorter reverb times and correspondingly lower sample rates mean longer reverb times.

Is this only the case for the (old) standard Reverb effect or also for the new ones? (Should we even keep the old one once we have the new ones?)

The DAC crashes during many performances. When loading a performance, there is a loud cracking sound and the audio output can only be revived by restarting. I have not yet found a common cause for this.

Can you please give a few examples so that we can replicate?

[probonopd]

Noticed the following:

When I switch on MiniDexed, play a bit, and then just let it sit for a while (e.g., half an hour to an hour) and then try to play again, it stays silent. On Raspberry Pi Zero 2 W with Keystation Mini32 MK3. (Not sure whether this is a hardware issue and/or whether it also happens with the normal MiniDexed version. Just something to watch out for.)

[Banana71]

So far I have not tested other sample rates. Do you know sample rates that work with the normal build but not with this one?

A sample rate of 48000 and the use of effects on all TGs causes crackling in the sound output. I haven't tested other sample rates up to 22000. I haven't tried fewer TGs either.

The "Save as default" command does not work correctly. The first performance of the current bank is overwritten. (Probably a bug that applies to all versions)
Can you please retest this with the normal version and open a bug if it is there too?

The main version is also affected.

I only noticed the dependence of the reverb time on the sample rate with the old standard reverb.

e.g. the DAC crashes with the following performances: 001:041 Barock, 001:065 1984, 002:001 mDx-Strg.AT (which is why I can't test the Greenhouse bank)

The feedback parameter for the delay effect is incorrect. If the feedback value is set to zero, the delay should work like an echo. Unfortunately, there is then no echo at all. I hope you understand what I mean

[probonopd]

I only noticed the dependence of the reverb time on the sample rate with the old standard reverb.

Ah right, that's a known issue of the old reverb, so unrelated to this change.

• Reverb time depends on the sample rate #563

[Banana71]

The effects chain has been changed more often now and I think it has gotten better and better. But as I would like it to be.

In each TG the following: Send FX 1, Send FX 2, EQ
under Effects: FX1, FX2, Compressor, The parameters of the compressor should be changeable (threshold, ratio, input, output, gain or whatever the compressor can do). The compressor should always be at the last position in the chain.

[Banana71]

It would be sad if nothing was done at this point.

[probonopd]

@jnonis: Please let us know when this is function-wise ready for being merged from your perspective.

We then all will need to test it on all RPi models we have access to.

I would be fine with the entire FX code path being disabled on RPi 1 and RPi Zero (but not RPi Zero 2).

[jnonis]

Hi @probonopd,
I won't me able to work on this next 2 weeks.
At this point I have 3 things that needs work:

• Configuration property to disable all The FXs
• Remove or make optional the chages to get performance for single core RPis, this makes the display slower but give priority to sound processing.
• Test in RPi 4

I think I can do this in a weekend when I will be back.