-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Publish HTML documentation preview on surge #128
Conversation
Closing to test the surge teardown |
45cb133
to
7267bf4
Compare
7267bf4
to
9aa5836
Compare
The error occurs both when the surge preview is called in the same job of the documentation is built or when it is in a dedicated job. |
…f documentation comment) The header doesn't document function, so we shouldn't use documentation block
This reverts commit ef722c0.
Retesting the surge teardown, closing the PR temporary. The actual domain is using lower case, whereas the domain name checked for existence contains upper case parts (the name of the repository, in our case
Detailed logs:
|
# Conflicts: # CONTRIBUTING.md
Co-authored-by: Souchet Céline <[email protected]>
Co-authored-by: Thomas Bouffard <[email protected]>
When documentation source files change, publish the generated documentation to surge to easy the review.
Create a workflow that will later include a job to publish to
gh-pages
.The HTML documentation content is not customized nor updated. This will be done later.
refs #19
refs #40 (HTML documentation improvements)
closes #125
Completed tasks
documentation generation
GH workflow
Notes
In the 1st commits of this PR, there was an attempt to have a job to build the documentation and others to deploy.
The build documentation job would be skipped . I tried to use a condition to skip it for surge teardown, but in this case the dependent job doing the surge teardown wasn't called.
The issue seems coming from actions/runner#491
The surge teardown is configured but it is not effective. See #128 (comment)
This is not a blocker: a schedule task teardowns stale deployments on regular basis, so even if the deployment is not remove when the PR is closed, this will be done few days later.