Use bash to build json arrays and drop unmaintained action #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klutchell
force-pushed
the
kyle/json-array-builder
branch
4 times, most recently
from
851e361 to
410aad5
Compare
Change-type: patch Signed-off-by: Kyle Harding <[email protected]>
klutchell
force-pushed
the
kyle/json-array-builder
branch
2 times, most recently
from
e7e6385 to
22f5ffd
Compare
This is for compatibility with existing matrix definitions that do not handle empty arrays as we would hope. Signed-off-by: Kyle Harding <[email protected]>
klutchell
force-pushed
the
kyle/json-array-builder
branch
from
22f5ffd to
804475d
Compare
Page-
approved these changes
Feb 16, 2024
| set -x | ||
|
|
||
| # Remove spaces and newlines from the input | ||
| INPUT="$(echo "${INPUT}" | tr -d '[:space:]')" |
There was a problem hiding this comment.
I think this is deleting all spaces, not just those around the quoted elements, but it's also not new to this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-type: patch
See: #878