Dev 16940 1 #8
Merged
Dev 16940 1 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Linked to Story DEV-16940 · Custom: Shopify Metafields |
composer.lockClick to show 104 changes in this composer.lock filePackage changesDev Package changes
Add your project as a package to Private Packagist to benefit from security monitoring of your dependencies.Settings · Docs · Powered by Private Packagist |
|
The composer.lock diff comment has been updated to reflect new changes in this PR. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more Footnotes
|
jacekgadomski
approved these changes
Apr 18, 2024
jacekgadomski
requested changes
Apr 18, 2024
|
The composer.lock diff comment has been updated to reflect new changes in this PR. |
|
The composer.lock diff comment has been updated to reflect new changes in this PR. |
|
The composer.lock diff comment has been updated to reflect new changes in this PR. |
jacekgadomski
requested changes
Apr 26, 2024
| 'Content-Type' => 'application/json', | ||
| ], | ||
| ]); | ||
| $this->responseHandler->handle(json_decode($response->getBody()->getContents(), true), $data, $metafield); |
There was a problem hiding this comment.
exeptions are not properly handled, ie: json is not handled
There was a problem hiding this comment.
json exception added
| { | ||
| return [ | ||
| 'id' => $this->ownerId, | ||
| 'metafield' => json_encode($this->metafield), |
kamil-fityka
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change. And don't forget to add the related Jira Issue ID (e.g.
DEV-7327). Swarmia adding then automatically the link to the PR.
Checklist: