[Do Not Merge] Android CHIPTool build support through openjdk 17 #27377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple and
lazarkov
pullapprove
bot
requested review from
msandstedt,
mspang,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic and
tehampson
pullapprove
bot
requested review from
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
|
PR #27377: Size comparison from 534b6d9 to 0e20d15 Increases (10 builds for bl602, bl702, nrfconnect, psoc6, telink)
Decreases (13 builds for bl602, esp32, psoc6, telink)
Full report (46 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
@satyajitanand Sorry, I don't know much about the situation with Android CHIPTool (not to be confused with the chip-tool command line utility). |
bzbarsky-apple
changed the title
andy31415
requested changes
Jun 23, 2023
There was a problem hiding this comment.
Commented on the original bug report: for compile logic that currently passes CI, I would look at integrations/docker/images for chip-build-android and chip-build-java.
Those compilations currently pass, so I imagine we should rather update the docs instead of trying to adjust the code to match the docs, because the documentation is probably obsolete.
andy31415
reviewed
Jun 23, 2023
| repositories { | ||
| google() | ||
| mavenCentral() | ||
| } | ||
| dependencies { | ||
| classpath "com.android.tools.build:gradle:4.2.0" | ||
| classpath "com.android.tools.build:gradle:7.3.0" |
There was a problem hiding this comment.
I like this change as a stand-alone (assuming it passes CI): we should update tools versions unless it causes some compatibility issues.
For the version going backwards however (kotlin version above) , I believe a strong justification is needed on why going backward in time is correct.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
This stale pull request has been automatically closed. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27374
This is only intended for the review purpose first to solve out the above situation (so marked as Do Not Merge).
@andy31415 and @bzbarsky-apple : I am not sure if many people facing the similar problem. If you think, the documentation should have such mentioning (to build through openjdk 17) or relevant code should be pushed under "java 17" version check to provide build support, I can make the change accordingly as per your suggestion.