Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update of Appliance Cluster XML to reflect Spec changes that took place in 1.4 #36994

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from
Draft

Update of Appliance Cluster XML to reflect Spec changes that took place in 1.4 #36994

wants to merge 17 commits into from
+327 −3,486

Conversation

marktrayer
Copy link
Collaborator

@marktrayer marktrayer commented Jan 8, 2025 •
edited
Loading

See issue #30383
Update XML to align with spec.
Regen Zap files.
Update app cluster implementations as appropritate

Testing

TBA

@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Jan 8, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  src/app/zap-templates/zcl/data-model/chip/oven-mode-cluster.xml  86% smaller
  src/app/zap-templates/zcl/data-model/chip/dishwasher-mode-cluster.xml  29% smaller
  src/app/zap-templates/zcl/data-model/chip/operational-state-oven-cluster.xml  28% smaller
  src/controller/java/generated/java/chip/devicecontroller/ClusterIDMapping.java  26% smaller
  src/app/zap-templates/zcl/data-model/chip/laundry-washer-mode-cluster.xml  12% smaller
  src/app/zap-templates/zcl/data-model/chip/refrigerator-and-temperature-controlled-cabinet-mode-cluster.xml  12% smaller
  examples/all-clusters-app/all-clusters-common/all-clusters-app.matter Unsupported file format
  examples/all-clusters-app/all-clusters-common/src/dishwasher-mode.cpp Unsupported file format
  examples/all-clusters-app/all-clusters-common/src/laundry-washer-mode.cpp Unsupported file format
  examples/all-clusters-app/all-clusters-common/src/microwave-oven-mode.cpp Unsupported file format
  examples/all-clusters-app/all-clusters-common/src/tcc-mode.cpp Unsupported file format
  examples/chef/devices/rootnode_dishwasher_cc105034fe.matter Unsupported file format
  examples/chef/devices/rootnode_laundrywasher_fb10d238c8.matter Unsupported file format
  examples/chef/devices/rootnode_refrigerator_temperaturecontrolledcabinet_temperaturecontrolledcabinet_ffdb696680.matter Unsupported file format
  examples/laundry-washer-app/nxp/zap/laundry-washer-app.matter Unsupported file format
  examples/microwave-oven-app/microwave-oven-common/microwave-oven-app.matter Unsupported file format
  examples/refrigerator-app/silabs/data_model/refrigerator-thread-app.matter Unsupported file format
  examples/refrigerator-app/silabs/data_model/refrigerator-wifi-app.matter Unsupported file format
  scripts/tools/zap/tests/outputs/all-clusters-app/app-templates/endpoint_config.h Unsupported file format
  scripts/tools/zap/tests/outputs/all-clusters-app/app-templates/gen_config.h Unsupported file format
  scripts/tools/zap/tests/outputs/lighting-app/app-templates/endpoint_config.h Unsupported file format
  src/app/zap-templates/zcl/data-model/chip/microwave-oven-mode-cluster.xml  0% smaller
  src/app/zap-templates/zcl/data-model/chip/mode-base-cluster.xml  0% smaller
  src/controller/data_model/controller-clusters.matter Unsupported file format
  src/controller/java/generated/java/chip/devicecontroller/ChipClusters.java  0% smaller
  src/controller/java/generated/java/chip/devicecontroller/ClusterInfoMapping.java  0% smaller
  src/controller/java/generated/java/chip/devicecontroller/ClusterReadMapping.java  0% smaller
  src/controller/java/generated/java/chip/devicecontroller/ClusterWriteMapping.java  0% smaller
  src/controller/java/generated/java/matter/controller/cluster/clusters/DishwasherModeCluster.kt Unsupported file format
  src/controller/java/generated/java/matter/controller/cluster/clusters/LaundryWasherModeCluster.kt Unsupported file format
  src/controller/java/generated/java/matter/controller/cluster/clusters/OvenCavityOperationalStateCluster.kt Unsupported file format
  src/controller/java/generated/java/matter/controller/cluster/clusters/RefrigeratorAndTemperatureControlledCabinetModeCluster.kt Unsupported file format
  src/controller/java/zap-generated/CHIPAttributeTLVValueDecoder.cpp Unsupported file format
  src/controller/python/chip/clusters/CHIPClusters.py  0% smaller
  src/controller/python/chip/clusters/Objects.py  0% smaller
  zzz_generated/app-common/app-common/zap-generated/attributes/Accessors.cpp Unsupported file format
  zzz_generated/app-common/app-common/zap-generated/attributes/Accessors.h Unsupported file format
  zzz_generated/app-common/app-common/zap-generated/cluster-enums.h Unsupported file format
  zzz_generated/app-common/app-common/zap-generated/cluster-objects.cpp Unsupported file format
  zzz_generated/app-common/app-common/zap-generated/cluster-objects.h Unsupported file format
  zzz_generated/app-common/app-common/zap-generated/ids/Attributes.h Unsupported file format
  zzz_generated/app-common/app-common/zap-generated/ids/Commands.h Unsupported file format
  zzz_generated/chip-tool/zap-generated/cluster/Commands.h Unsupported file format
  zzz_generated/chip-tool/zap-generated/cluster/logging/DataModelLogger.cpp Unsupported file format
  zzz_generated/chip-tool/zap-generated/cluster/logging/EntryToText.cpp Unsupported file format
  zzz_generated/darwin-framework-tool/zap-generated/cluster/Commands.h Unsupported file format

@github-actions github-actions bot added the app label Jan 8, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

PR #36994: Size comparison from dedef1f to c05c603

Full report (3 builds for cc32xx, stm32)
platform target config section dedef1f c05c603 change % change
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 540049 540049 0 0.0
RAM 205800 205800 0 0.0
lock CC3235SF_LAUNCHXL FLASH 574217 574217 0 0.0
RAM 205944 205944 0 0.0
stm32 light STM32WB5MM-DK FLASH 485080 485080 0 0.0
RAM 144912 144912 0 0.0

@github-actions GitHub Actions
Copy link

PR #36994: Size comparison from 47a95b9 to 4bc96e5

Full report (3 builds for cc32xx, stm32)
platform target config section 47a95b9 4bc96e5 change % change
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538433 538433 0 0.0
RAM 205192 205192 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572297 572297 0 0.0
RAM 205344 205344 0 0.0
stm32 light STM32WB5MM-DK FLASH 482608 482608 0 0.0
RAM 144672 144672 0 0.0

@github-actions GitHub Actions
Copy link

PR #36994: Size comparison from 47a95b9 to 4b86731

Full report (3 builds for cc32xx, stm32)
platform target config section 47a95b9 4b867311 change % change
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538433 538433 0 0.0
RAM 205192 205192 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572297 572297 0 0.0
RAM 205344 205344 0 0.0
stm32 light STM32WB5MM-DK FLASH 482608 482608 0 0.0
RAM 144672 144672 0 0.0

@github-actions GitHub Actions
Copy link

PR #36994: Size comparison from 47a95b9 to cda0fdd

Full report (1 build for stm32)
platform target config section 47a95b9 cda0fdd change % change
stm32 light STM32WB5MM-DK FLASH 482608 482608 0 0.0
RAM 144672 144672 0 0.0

@marktrayer marktrayer force-pushed the issue_30383_appliancexmlcleanup-2 branch from cda0fdd to 3d4e9b3 Compare January 23, 2025 21:08
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2025 •
edited
Loading

PR #36994: Size comparison from 43f37d1 to 3d4e9b3

Full report (5 builds for cc32xx, stm32, tizen)
platform target config section 43f37d1 3d4e9b3 change % change
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538437 538437 0 0.0
RAM 205192 205192 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572301 572301 0 0.0
RAM 205344 205344 0 0.0
stm32 light STM32WB5MM-DK FLASH 482592 482592 0 0.0
RAM 144672 144672 0 0.0
tizen all-clusters-app arm unknown 5116 5116 0 0.0
FLASH 1751752 1751744 -8 -0.0
RAM 93524 93452 -72 -0.1
chip-tool-ubsan arm unknown 11024 11008 -16 -0.1
FLASH 18211902 18196414 -15488 -0.1
RAM 7954076 7947652 -6424 -0.1

@github-actions GitHub Actions
Copy link

PR #36994: Size comparison from 43f37d1 to 5fc7482

Full report (7 builds for cc13x4_26x4, cc32xx, stm32)
platform target config section 43f37d1 5fc7482 change % change
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 837992 837992 0 0.0
RAM 123464 123464 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 823396 823396 0 0.0
RAM 125344 125344 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 770612 770612 0 0.0
RAM 113804 113804 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 754872 754872 0 0.0
RAM 114012 114012 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538437 538437 0 0.0
RAM 205192 205192 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572301 572301 0 0.0
RAM 205344 205344 0 0.0
stm32 light STM32WB5MM-DK FLASH 482592 482592 0 0.0
RAM 144672 144672 0 0.0

@github-actions GitHub Actions
Copy link

PR #36994: Size comparison from 14ac7a6 to 8649f7e

Full report (3 builds for cc32xx, stm32)
platform target config section 14ac7a6 8649f7e change % change
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538437 538437 0 0.0
RAM 205192 205192 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572301 572301 0 0.0
RAM 205344 205344 0 0.0
stm32 light STM32WB5MM-DK FLASH 482592 482592 0 0.0
RAM 144672 144672 0 0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
app controller examples scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marktrayer @restyled-commits