[Realtek] First porting Bee4 #37005
Open
[Realtek] First porting Bee4 #37005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #37005: Size comparison from f25f635 to c90548e Full report (3 builds for cc32xx, stm32)
|
|
PR #37005: Size comparison from f25f635 to d4bb589 Full report (3 builds for cc32xx, stm32)
|
|
PR #37005: Size comparison from f25f635 to a274c97 Full report (3 builds for cc32xx, stm32)
|
andy31415
reviewed
Jan 9, 2025
andy31415
added
the
changing-submodules-on-purpose
andy31415
requested changes
Jan 9, 2025
There was a problem hiding this comment.
This is a very large change. Please make sure CI passes and also expand the Summary with details:
- what is Bee4
- what examples were added/general TLDR on changes
- add a
### Testingsection: how did you check that the things you added work correctly (and how can others in the future do the same?). Were there any tests added/updated? There are no CI changes so how will "this compiles" be enforced over time? if you add CI how much overhead is added for it?
|
PR #37005: Size comparison from f25f635 to bd8c910 Increases above 0.2%:
Full report (55 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37005: Size comparison from d5e9829 to 953fa57 Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
Please help to check again |
andy31415
reviewed
Jan 14, 2025
third_party/bee_sdk/bee_sdk.gni
Outdated
| import("//build_overrides/bee_sdk.gni") | ||
| declare_args() { | ||
| # Location of the BEE SDK. | ||
| bee_sdk_root = "${chip_root}/third_party/bee_sdk" |
There was a problem hiding this comment.
Is this supposed to contain a submodule? How is this compiled?
andy31415
reviewed
Jan 14, 2025
| ## Realtek SDK | ||
|
|
||
| More detailed information on the Bee4 SDK can be found in the | ||
| [Realtek Matter SDK](https://github.com/rtkconnectivity/rtl87x2g_sdk). |
There was a problem hiding this comment.
There should be some instructions on how to compile in the SDK itself. likely some build-examples.py line.
andy31415
requested changes
Jan 14, 2025
There was a problem hiding this comment.
CI seems to pass. We still need to have this integrated in our build system:
- add build_examples.py compile support
- update README.md to describe how to build if anything is required
I would like to ensure we can easily get the SDK and it is not under some login/NDA/other agreement link.
andy31415
reviewed
Jan 14, 2025
config/realtek_bee/chip.cmake
Outdated
| ${CHIP_ROOT}/src/app | ||
| ${CHIP_ROOT}/src/platform/Realtek_bee | ||
| ${CHIP_ROOT}/src/platform/OpenThread | ||
| # ${CHIP_ROOT}/src/lwip/bee |
There was a problem hiding this comment.
remove commented out lines
|
I have updated the README file for each sample to include detailed build instructions. Please help to check again |
andy31415
reviewed
Jan 20, 2025
There was a problem hiding this comment.
what are the different 1_to_2 and 1_to_8 and 1_to_11 and such mean? please describe the PR in the PR summary.
andy31415
reviewed
Jan 20, 2025
| #endif | ||
|
|
||
| #if CONFIG_ENABLE_ATTRIBUTE_SUBSCRIBE | ||
| // TriggerSubscribe(); |
There was a problem hiding this comment.
why is there commented out code here?
andy31415
reviewed
Jan 20, 2025
| ## Building | ||
|
|
||
| user@ubuntu:~/Desktop/git/connectedhomeip$ cd ./third_party/openthread/ot-realtek | ||
| user@ubuntu:~/Desktop/git/connectedhomeip/third_party/openthread/ot-realtek$ OT_CMAKE_NINJA_TARGET="matter-cli-ftd" ./Realtek/build bee4 sdk rtl8777g lighting-app |
There was a problem hiding this comment.
what is ./Realtek/build ?
please integrate the build system into scripts/build/build_examples.py so we have a standard way to build things.
The existing instructions seem to reference an out of tree build system that will be hard to maintain from the SDK side.
|
PR #37005: Size comparison from 03fe653 to 975ef1d Full report (3 builds for cc32xx, stm32)
|
|
PR #37005: Size comparison from 03fe653 to e00e293 Increases above 0.2%:
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37005: Size comparison from 03fe653 to 6d80193 Increases above 0.2%:
Full report (45 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37005: Size comparison from 03fe653 to f2ec8ac Increases above 0.2%:
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bee4 is the codename for Realtek RTL87X2G series IC
We have added support for several matter applications on our SoC board-RTL8777G SOC board, including: lighting，switch，window，lock
The main difference between light-switch-app-1_to_2.matter , light-switch-app-1_to_8.matter, light-switch-app-1_to_11.matter, as suggested by the file names, is likely the number of endpoints they support,Increasing the number of supported endpoints usually means that more devices can be connected and controlled.
Testing
We conducted thorough testing on local RTL8777G SOC boards. This included building the applications, performing commissioning processes, and verifying the basic functionality of the sample-lighting, switch, window, and lock applications.
There is no test added at present. We will temporarily ensure that there are no problems with the version compilation before uploading it. We will push it to be added in future