[Silabs] Changes the WiFi initialization for RCP modules #37135
+16
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
rosahay-silabs
changed the title
|
PR #37135: Size comparison from 8370039 to e489f7b Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37135: Size comparison from 8370039 to 43cd521 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
mkardous-silabs
requested changes
Jan 22, 2025
| @@ -45,11 +45,12 @@ | |||
| #include "MemMonitoring.h" | |||
| #endif | |||
|
|
|||
| // TODO: We shouldn't need any platform specific includes in this file | |||
There was a problem hiding this comment.
You are removing TODOs without resolving them.
| @@ -320,10 +321,9 @@ CHIP_ERROR SilabsMatterConfig::InitWiFi(void) | |||
| wfx_bus_start(); | |||
| #endif // WF200_WIFI | |||
|
|
|||
| // TODO: Platform specific init should not be required here | |||
There was a problem hiding this comment.
Now that init structure between all our Wi-Fi implementations are similar, we can unify the inits here behind a common init the WifiInterface header.
Please create a function in the WifiInterface.h, that is implemented by all the WifiInterfaceImpl including the WF200.
| @@ -646,15 +638,20 @@ void ProcessEvent(WifiPlatformEvent event) | |||
| } | |||
| } | |||
|
|
|||
| void MatterWifiTask(void * arg) | |||
| sl_status_t InitSiWxWifi(void) | |||
There was a problem hiding this comment.
If this function is used by the rs911x WifiInterfaceImpl, the name needs to be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
Manually build the RCP combinations for RS9116 and RCP 917 with EFR32MG24.