Map "chip" Python imports as first-party #37138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
|
PR #37138: Size comparison from 8370039 to e8405c5 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37138: Size comparison from f3202b1 to 3f2fc0c Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37138: Size comparison from 22cd392 to 385212c Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tehampson
reviewed
Jan 27, 2025
tehampson
reviewed
Jan 27, 2025
tehampson
reviewed
Jan 27, 2025
| @@ -12,12 +12,12 @@ | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
|
|
|||
| from matter_idl.matter_idl_types import Idl | |||
There was a problem hiding this comment.
Does is make sense to include other things like matter_idl in known first party? I don't know one way or another just asking
There was a problem hiding this comment.
I think that it would be better to change the namespace of that module. But now the question might be whether it would be worth of changing it to chip? Since, the entire project is going to be renamed, maybe we can "correct" the Python module name as well and name it matter.idl?
There was a problem hiding this comment.
It seems that we could "claim" the matter namespace and release the chip: https://pypi.org/search/?q=matter
tehampson
reviewed
Jan 27, 2025
| @@ -46,13 +46,14 @@ | |||
| __ALL__ = (matter_idl_types) | |||
|
|
|||
|
|
|||
| import click | |||
| from matter_yamltests.definitions import SpecDefinitionsFromPaths | |||
| from matter_yamltests.parser import PostProcessCheckStatus, TestParser, TestParserConfig | |||
There was a problem hiding this comment.
same with matter_yamltests, should it be considered first party?
There was a problem hiding this comment.
Same as above. Maybe it should be matter.yamltests?
There was a problem hiding this comment.
I think matter.* would be better. Unsure if we used the current naming to satisfy our build rules ... if we do not have to fight it very hard, I prefer matter.testing and matter.yamltests and such.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
CHIP imports are intermixed with 3rd party imports. Since,
chipis "reserved" namespace for CHIP project, we can mark it as first-party from our point of view. This should improve imports readability.Commit 0d3c003 was created by running
isorton entire codebase.Changes
Testing
CI should catch any issues with this PR