Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Silabs] Added join callback handler to fix rejoin issue #37145

Merged
merged 5 commits into from
Jan 24, 2025
Merged

[Silabs] Added join callback handler to fix rejoin issue #37145

merged 5 commits into from
Jan 24, 2025
+38 −7

Conversation

senthilku
Copy link
Contributor

Changelog

  • Added a join callback handler
  • The unnecessary join events have been removed. The join event is posted multiple times, causing issues with the ecosystem during AP power cycles.

Testing

Manually tested commissioning and power cycle with 917 SoC

@senthilku senthilku requested a review from a team as a code owner January 21, 2025 18:19
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with  SemanticDiff

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 21, 2025 •
edited
Loading

PR #37145: Size comparison from bdbd217 to 8be6af2

Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section bdbd217 8be6af28 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1092018 1092018 0 0.0
RAM 103258 103258 0 0.0
bl702 lighting-app bl702+eth FLASH 650236 650236 0 0.0
RAM 25265 25265 0 0.0
bl702+wifi FLASH 828106 828106 0 0.0
RAM 13981 13981 0 0.0
bl706+mfd+rpc+littlefs FLASH 1055136 1055136 0 0.0
RAM 23845 23845 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 888134 888134 0 0.0
RAM 18504 18504 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 971120 971120 0 0.0
RAM 16368 16368 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 838024 838024 0 0.0
RAM 123448 123448 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 823452 823452 0 0.0
RAM 125320 125320 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 770636 770636 0 0.0
RAM 113804 113804 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 754888 754888 0 0.0
RAM 114012 114012 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538433 538433 0 0.0
RAM 205192 205192 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572369 572369 0 0.0
RAM 205320 205320 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 679473 679473 0 0.0
RAM 78508 78508 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 699317 699317 0 0.0
RAM 81148 81148 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 699317 699317 0 0.0
RAM 81148 81148 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 656253 656253 0 0.0
RAM 73576 73576 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 615833 615833 0 0.0
RAM 71492 71492 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635461 635461 0 0.0
RAM 74036 74036 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635461 635461 0 0.0
RAM 74036 74036 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635329 635329 0 0.0
RAM 74500 74500 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 655045 655045 0 0.0
RAM 77044 77044 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 655045 655045 0 0.0
RAM 77044 77044 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 611773 611773 0 0.0
RAM 68588 68588 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631633 631633 0 0.0
RAM 71228 71228 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631633 631633 0 0.0
RAM 71228 71228 0 0.0
efr32 lock-app BRD4187C FLASH 934704 934704 0 0.0
RAM 159904 159904 0 0.0
BRD4338a FLASH 729580 729692 112 0.0
RAM 234748 234748 0 0.0
window-app BRD4187C FLASH 1029288 1029280 -8 -0.0
RAM 128008 128008 0 0.0
esp32 all-clusters-app c3devkit DRAM 95088 95088 0 0.0
FLASH 1536870 1536870 0 0.0
IRAM 82552 82552 0 0.0
m5stack DRAM 116076 116076 0 0.0
FLASH 1544954 1544954 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4752 4752 0 0.0
FLASH 2708845 2708845 0 0.0
RAM 132800 132800 0 0.0
all-clusters-app debug unknown 5560 5560 0 0.0
FLASH 5974698 5974698 0 0.0
RAM 531520 531520 0 0.0
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5322484 5322484 0 0.0
RAM 242632 242632 0 0.0
bridge-app debug unknown 5472 5472 0 0.0
FLASH 4680640 4680640 0 0.0
RAM 221368 221368 0 0.0
chip-tool debug unknown 5984 5984 0 0.0
FLASH 13046528 13046528 0 0.0
RAM 596178 596178 0 0.0
chip-tool-ipv6only arm64 unknown 21776 21776 0 0.0
FLASH 1112372 1112372 0 0.0
RAM 647920 647920 0 0.0
fabric-admin debug unknown 5808 5808 0 0.0
FLASH 11393503 11393503 0 0.0
RAM 596522 596522 0 0.0
fabric-bridge-app debug unknown 4728 4728 0 0.0
FLASH 4506068 4506068 0 0.0
RAM 208552 208552 0 0.0
fabric-sync debug unknown 4968 4968 0 0.0
FLASH 5611141 5611141 0 0.0
RAM 483424 483424 0 0.0
lighting-app debug+rpc+ui unknown 6136 6136 0 0.0
FLASH 5615681 5615681 0 0.0
RAM 231648 231648 0 0.0
lock-app debug unknown 5408 5408 0 0.0
FLASH 4730586 4730586 0 0.0
RAM 207616 207616 0 0.0
ota-provider-app debug unknown 4768 4768 0 0.0
FLASH 4359432 4359432 0 0.0
RAM 201352 201352 0 0.0
ota-requestor-app debug unknown 4720 4720 0 0.0
FLASH 4496936 4496936 0 0.0
RAM 205936 205936 0 0.0
shell debug unknown 4248 4248 0 0.0
FLASH 3004781 3004781 0 0.0
RAM 160408 160408 0 0.0
thermostat-no-ble arm64 unknown 9536 9536 0 0.0
FLASH 4098720 4098720 0 0.0
RAM 246064 246064 0 0.0
tv-app debug unknown 5736 5736 0 0.0
FLASH 5951077 5951077 0 0.0
RAM 606824 606824 0 0.0
tv-casting-app debug unknown 5312 5312 0 0.0
FLASH 11271213 11271213 0 0.0
RAM 710736 710736 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 913664 913664 0 0.0
RAM 143148 143148 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 888544 888544 0 0.0
RAM 141335 141335 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 848552 848552 0 0.0
RAM 142060 142060 0 0.0
nxp contact k32w0+release FLASH 584288 584288 0 0.0
RAM 70860 70860 0 0.0
mcxw71+release FLASH 599632 599632 0 0.0
RAM 63080 63080 0 0.0
light k32w0+release FLASH 610716 610716 0 0.0
RAM 70252 70252 0 0.0
k32w1+release FLASH 685184 685184 0 0.0
RAM 48664 48664 0 0.0
lock mcxw71+release FLASH 761264 761264 0 0.0
RAM 70708 70708 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646340 1646340 0 0.0
RAM 211544 211544 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1552892 1552892 0 0.0
RAM 208352 208352 0 0.0
light cy8ckit_062s2_43012 FLASH 1468780 1468780 0 0.0
RAM 200328 200328 0 0.0
lock cy8ckit_062s2_43012 FLASH 1466828 1466828 0 0.0
RAM 224672 224672 0 0.0
qpg lighting-app qpg6105+debug FLASH 661992 661992 0 0.0
RAM 105204 105204 0 0.0
lock-app qpg6105+debug FLASH 619772 619772 0 0.0
RAM 99648 99648 0 0.0
stm32 light STM32WB5MM-DK FLASH 482648 482648 0 0.0
RAM 144656 144656 0 0.0
telink bridge-app tlsr9258a FLASH 681396 681396 0 0.0
RAM 91064 91064 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621608 621608 0 0.0
RAM 31464 31464 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 770454 770454 0 0.0
RAM 49324 49324 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 774872 774872 0 0.0
RAM 99628 99628 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 708782 708782 0 0.0
RAM 73356 73356 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625882 625882 0 0.0
RAM 141996 141996 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 811932 811932 0 0.0
RAM 99540 99540 0 0.0
tizen all-clusters-app arm unknown 5112 5112 0 0.0
FLASH 1751184 1751184 0 0.0
RAM 93468 93468 0 0.0
chip-tool-ubsan arm unknown 11024 11024 0 0.0
FLASH 18213494 18213494 0 0.0
RAM 7955128 7955128 0 0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 24, 2025 •
edited
Loading

PR #37145: Size comparison from 080185d to bdc2b29

Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 080185d bdc2b29 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1093530 1093530 0 0.0
RAM 103298 103298 0 0.0
bl702 lighting-app bl702+eth FLASH 650142 650142 0 0.0
RAM 25265 25265 0 0.0
bl702+wifi FLASH 828050 828050 0 0.0
RAM 13981 13981 0 0.0
bl706+mfd+rpc+littlefs FLASH 1056602 1056602 0 0.0
RAM 23861 23861 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 888036 888036 0 0.0
RAM 18504 18504 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 971022 971022 0 0.0
RAM 16368 16368 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 837992 837992 0 0.0
RAM 123464 123464 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 823396 823396 0 0.0
RAM 125344 125344 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 770612 770612 0 0.0
RAM 113804 113804 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 754872 754872 0 0.0
RAM 114012 114012 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538437 538437 0 0.0
RAM 205192 205192 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572301 572301 0 0.0
RAM 205344 205344 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 679393 679393 0 0.0
RAM 78532 78532 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 699245 699245 0 0.0
RAM 81172 81172 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 699245 699245 0 0.0
RAM 81172 81172 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 656173 656173 0 0.0
RAM 73600 73600 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 615777 615777 0 0.0
RAM 71516 71516 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635405 635405 0 0.0
RAM 74060 74060 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635405 635405 0 0.0
RAM 74060 74060 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635249 635249 0 0.0
RAM 74524 74524 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 654957 654957 0 0.0
RAM 77068 77068 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 654957 654957 0 0.0
RAM 77068 77068 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 611693 611693 0 0.0
RAM 68612 68612 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631553 631553 0 0.0
RAM 71252 71252 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631553 631553 0 0.0
RAM 71252 71252 0 0.0
efr32 lock-app BRD4187C FLASH 936232 936232 0 0.0
RAM 159904 159904 0 0.0
BRD4338a FLASH 729484 729596 112 0.0
RAM 234768 234768 0 0.0
window-app BRD4187C FLASH 1029160 1029152 -8 -0.0
RAM 128040 128040 0 0.0
esp32 all-clusters-app c3devkit DRAM 97296 97296 0 0.0
FLASH 1577024 1577024 0 0.0
IRAM 83820 83820 0 0.0
m5stack DRAM 116092 116092 0 0.0
FLASH 1544974 1544974 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4760 4760 0 0.0
FLASH 2708469 2708469 0 0.0
RAM 132800 132800 0 0.0
all-clusters-app debug unknown 5568 5568 0 0.0
FLASH 5974524 5974524 0 0.0
RAM 531616 531616 0 0.0
all-clusters-minimal-app debug unknown 5464 5464 0 0.0
FLASH 5323210 5323210 0 0.0
RAM 242728 242728 0 0.0
bridge-app debug unknown 5480 5480 0 0.0
FLASH 4681398 4681398 0 0.0
RAM 221464 221464 0 0.0
chip-tool debug unknown 5984 5984 0 0.0
FLASH 13042256 13042256 0 0.0
RAM 596178 596178 0 0.0
chip-tool-ipv6only arm64 unknown 21776 21776 0 0.0
FLASH 11118960 11118960 0 0.0
RAM 647920 647920 0 0.0
fabric-admin debug unknown 5808 5808 0 0.0
FLASH 11388337 11388337 0 0.0
RAM 596522 596522 0 0.0
fabric-bridge-app debug unknown 4736 4736 0 0.0
FLASH 4505996 4505996 0 0.0
RAM 208648 208648 0 0.0
fabric-sync debug unknown 4976 4976 0 0.0
FLASH 5612245 5612245 0 0.0
RAM 483520 483520 0 0.0
lighting-app debug+rpc+ui unknown 6144 6144 0 0.0
FLASH 5624177 5624177 0 0.0
RAM 231744 231744 0 0.0
lock-app debug unknown 5416 5416 0 0.0
FLASH 4730448 4730448 0 0.0
RAM 207712 207712 0 0.0
ota-provider-app debug unknown 4776 4776 0 0.0
FLASH 4359024 4359024 0 0.0
RAM 201352 201352 0 0.0
ota-requestor-app debug unknown 4728 4728 0 0.0
FLASH 4496528 4496528 0 0.0
RAM 205936 205936 0 0.0
shell debug unknown 4256 4256 0 0.0
FLASH 3004605 3004605 0 0.0
RAM 160504 160504 0 0.0
thermostat-no-ble arm64 unknown 9536 9536 0 0.0
FLASH 4098480 4098480 0 0.0
RAM 246136 246136 0 0.0
tv-app debug unknown 5744 5744 0 0.0
FLASH 5951861 5951861 0 0.0
RAM 606920 606920 0 0.0
tv-casting-app debug unknown 5320 5320 0 0.0
FLASH 11269245 11269245 0 0.0
RAM 710864 710864 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 913640 913640 0 0.0
RAM 143168 143168 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 888496 888496 0 0.0
RAM 141355 141355 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 848680 848680 0 0.0
RAM 142080 142080 0 0.0
nxp contact k32w0+release FLASH 584272 584272 0 0.0
RAM 70860 70860 0 0.0
mcxw71+release FLASH 599616 599616 0 0.0
RAM 63080 63080 0 0.0
light k32w0+release FLASH 610700 610700 0 0.0
RAM 70252 70252 0 0.0
k32w1+release FLASH 685168 685168 0 0.0
RAM 48664 48664 0 0.0
lock mcxw71+release FLASH 748632 748632 0 0.0
RAM 67476 67476 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646292 1646292 0 0.0
RAM 211560 211560 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1553068 1553068 0 0.0
RAM 208376 208376 0 0.0
light cy8ckit_062s2_43012 FLASH 1468748 1468748 0 0.0
RAM 200352 200352 0 0.0
lock cy8ckit_062s2_43012 FLASH 1466780 1466780 0 0.0
RAM 224688 224688 0 0.0
qpg lighting-app qpg6105+debug FLASH 661976 661976 0 0.0
RAM 105204 105204 0 0.0
lock-app qpg6105+debug FLASH 619756 619756 0 0.0
RAM 99648 99648 0 0.0
stm32 light STM32WB5MM-DK FLASH 482592 482592 0 0.0
RAM 144672 144672 0 0.0
telink bridge-app tlsr9258a FLASH 681350 681350 0 0.0
RAM 91084 91084 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621380 621380 0 0.0
RAM 31484 31484 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 770234 770234 0 0.0
RAM 49344 49344 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 774650 774650 0 0.0
RAM 99648 99648 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 708552 708552 0 0.0
RAM 73376 73376 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625660 625660 0 0.0
RAM 142016 142016 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 813032 813032 0 0.0
RAM 99560 99560 0 0.0
tizen all-clusters-app arm unknown 5116 5116 0 0.0
FLASH 1751752 1751752 0 0.0
RAM 93524 93524 0 0.0
chip-tool-ubsan arm unknown 11024 11024 0 0.0
FLASH 18211902 18211902 0 0.0
RAM 7954076 7954076 0 0.0

@yufengwangca yufengwangca merged commit 74593dc into project-chip:master Jan 24, 2025
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@yufengwangca yufengwangca yufengwangca approved these changes

Assignees
No one assigned
Labels
platform review - approved silabs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@senthilku @yufengwangca @jmartinez-silabs