Python test whl: Use zip files for data_model #37163
Draft
+55
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are close to the input parameter limit for the builds with the number of files in the data_model directory as-is. With the addition of the 1.4.1 files, we go over. Instead, we can zip the files and have the parser read directly from the zip archive. I think this also makes the whl slightly smaller, which is nice. Spec parsing is tested directly with TestSpecParsingSupport.py and with TestSpecParsingDeviceTypes.py. The TC_DeviceConformance tests also use the parsed spec.
|
Review changes with Changed Files
|
andy31415
reviewed
Jan 22, 2025
| @@ -12,9 +12,12 @@ | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
|
|
|||
| # Note: GN does not support file globbing. File list generated as follows: | |||
There was a problem hiding this comment.
there is a generate_data_model_xmls_gni.py
We should probably update that one instead.
And a note in this file should exist that it is script-generated
|
PR #37163: Size comparison from 2d0f857 to 9fad845 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are close to the input parameter limit for the builds with the number of files in the data_model directory as-is. With the addition of the 1.4.1 files, we go over. Instead, we can zip the files and have the parser read directly from the zip archive. I think this also makes the whl slightly smaller, which is nice.
Testing
Spec parsing is tested directly with TestSpecParsingSupport.py and with TestSpecParsingDeviceTypes.py. The TC_DeviceConformance tests also use the parsed spec.