Return InvalidCommand instead of UnsupportedCluster if the command is not handled in CHI #37166
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
yufengwangca
force-pushed
the
pr/cluster/dggen
branch
from
5701090 to
990f32f
Compare
andy31415
reviewed
Jan 23, 2025
| else | ||
| { | ||
| // If we reach here, it means this particular CommandHandlerInterface recognized the cluster but the command is invalid or cannot be processed. | ||
| handler->AddStatus(request.path, Protocols::InteractionModel::Status::InvalidCommand); |
There was a problem hiding this comment.
We previously allowed fallback to ember functions ... so this is not 100% backwards compatible (then again I am unsure if we should be or not).
I would lean more towards passing in a what to return on no handler found to the dispatch handler instead.
There was a problem hiding this comment.
But when it is fall-backed to the DispatchSingleClusterCommand, it just calls the following function to add status, what is the difference if we just add the status here?
if (errorStatus != Protocols::InteractionModel::Status::Success)
{
apCommandObj->AddStatus(aCommandPath, errorStatus);
}
990f32f to
c7022c9
Compare
… not handled in CHI
yufengwangca
force-pushed
the
pr/cluster/dggen
branch
from
c7022c9 to
5c36f8c
Compare
|
PR #37166: Size comparison from 47a95b9 to 5c36f8c Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37166: Size comparison from 47a95b9 to ec0298a Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, after switching to CHI, any unhandled command is returning Protocols::InteractionModel::Status::UnsupportedCluster. Previously, when Ember handled these commands, we would return Protocols::InteractionModel::Status::InvalidCommand. We should preserve that behavior and continue returning InvalidCommand for runhandled commands in CHI.
Testing
Verified by manually disable command Commands::ResetCounts in WiFiDiagnosticsServer