Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade MCAD to latest version #121

Merged
merged 3 commits into from
Aug 10, 2023
Merged

Upgrade MCAD to latest version #121

merged 3 commits into from
Aug 10, 2023

Conversation

astefanutti
Copy link
Contributor

@astefanutti astefanutti commented Aug 9, 2023 •
edited
Loading

This PR upgrades to the latest version of MCAD containing the upgrade to Kubernetes 1.26: project-codeflare/multi-cluster-app-dispatcher#552.

The main impacts are the required upgrade of the controller-runtime dependency to a compatible version, i.e., v0.14, and the upgrade to Golang 1.19.

z103cb
z103cb reviewed Aug 9, 2023
View reviewed changes
Copy link
Contributor

@z103cb z103cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start, upgrading go would make it LGTM.

@astefanutti
Copy link
Contributor Author

Great start, upgrading go would make it LGTM.

@z103cb Go upgraded to 1.19 with 11f8d47.

@asm582
Copy link
Member

asm582 commented Aug 9, 2023 •
edited
Loading

Thanks, @astefanutti! curios, are we planning to run manual e2e tests?

@astefanutti
Copy link
Contributor Author

Thanks, @astefanutti! curios, are we not running e2e tests?

@asm582 not directly from here (yet), plus we need to work on the e2e tests that'd cover InstaScale specifically.

@asm582
Copy link
Member

asm582 commented Aug 9, 2023

Thanks, @astefanutti! curios, are we not running e2e tests?

@asm582 not directly from here (yet), plus we need to work on the e2e tests that'd cover InstaScale specifically.

ok, thanks

/approve

@openshift-ci openshift-ci bot added the approved label Aug 9, 2023
z103cb
z103cb approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@z103cb z103cb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@openshift-ci openshift-ci bot added the lgtm label Aug 10, 2023
@z103cb
Copy link
Contributor

z103cb commented Aug 10, 2023

/Approve

@openshift-ci
Copy link

openshift-ci bot commented Aug 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asm582, z103cb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit c532879 into project-codeflare:main Aug 10, 2023
1 check passed
@astefanutti astefanutti deleted the pr-01 branch August 10, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@z103cb z103cb z103cb approved these changes

@asm582 asm582 Awaiting requested review from asm582

@Maxusmusti Maxusmusti Awaiting requested review from Maxusmusti

Assignees

@z103cb z103cb

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@astefanutti @asm582 @z103cb @openshift-merge-robot