Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MCAD CI check to validate special characters in branch name #532

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Fix MCAD CI check to validate special characters in branch name #532

merged 1 commit into from
Aug 2, 2023

Conversation

Srihari1192
Copy link
Contributor

@Srihari1192 Srihari1192 commented Aug 1, 2023 •
edited
Loading

Issue link

#531

What changes have been made

Added branch validation in step Set latest tag and Branch name in MCAD-CI check

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci
Copy link

openshift-ci bot commented Aug 1, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@Srihari1192 Srihari1192 marked this pull request as ready for review August 1, 2023 10:29
@Srihari1192 Srihari1192 marked this pull request as draft August 1, 2023 10:29
@Srihari1192 Srihari1192 marked this pull request as ready for review August 1, 2023 12:53
@openshift-ci openshift-ci bot requested a review from dimakis August 1, 2023 12:53
z103cb
z103cb reviewed Aug 1, 2023
View reviewed changes
Copy link
Contributor

@z103cb z103cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting for others to chime in.

@z103cb z103cb added the lgtm label Aug 2, 2023
@z103cb
Copy link
Contributor

z103cb commented Aug 2, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Aug 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: z103cb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 2, 2023
@openshift-merge-robot openshift-merge-robot merged commit acf42a9 into project-codeflare:main Aug 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@z103cb z103cb z103cb left review comments

@KPostOffice KPostOffice Awaiting requested review from KPostOffice

@metalcycling metalcycling Awaiting requested review from metalcycling

@asm582 asm582 Awaiting requested review from asm582

@anishasthana anishasthana Awaiting requested review from anishasthana

@dimakis dimakis Awaiting requested review from dimakis

Assignees
No one assigned
Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Srihari1192 @z103cb @openshift-merge-robot