-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial metrics #651
Open
ronensc
wants to merge
3
commits into
project-codeflare:main
Choose a base branch
from
ronensc:add-metrics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add initial metrics #651
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| /* | ||
| Copyright 2023 The Multi-Cluster App Dispatcher Authors. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package queuejob | ||
|
|
||
| import ( | ||
| "github.com/prometheus/client_golang/prometheus" | ||
| "sigs.k8s.io/controller-runtime/pkg/metrics" | ||
| ) | ||
|
|
||
| func registerMetrics(controller *XController) { | ||
| allocatableCapacityCpu := prometheus.NewGaugeFunc(prometheus.GaugeOpts{ | ||
| Subsystem: "mcad", | ||
| Name: "allocatable_capacity_cpu", | ||
| Help: "Allocatable CPU Capacity (in milicores)", | ||
| }, func() float64 { return controller.GetAllocatableCapacity().MilliCPU }) | ||
| metrics.Registry.MustRegister(allocatableCapacityCpu) | ||
|
|
||
| allocatableCapacityMemory := prometheus.NewGaugeFunc(prometheus.GaugeOpts{ | ||
| Subsystem: "mcad", | ||
| Name: "allocatable_capacity_memory", | ||
| Help: "Allocatable Memory Capacity", | ||
| }, func() float64 { return controller.GetAllocatableCapacity().Memory }) | ||
| metrics.Registry.MustRegister(allocatableCapacityMemory) | ||
|
|
||
| allocatableCapacityGpu := prometheus.NewGaugeFunc(prometheus.GaugeOpts{ | ||
| Subsystem: "mcad", | ||
| Name: "allocatable_capacity_gpu", | ||
| Help: "Allocatable GPU Capacity", | ||
| }, func() float64 { return float64(controller.GetAllocatableCapacity().GPU) }) | ||
| metrics.Registry.MustRegister(allocatableCapacityGpu) | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The calls to
GetAllocatableCapacity()are quite expensive to be executed in GaugeFuncs. Should I call it periodically and cache the values like in the original PR?https://github.com/project-codeflare/multi-cluster-app-dispatcher/pull/573/files#diff-cd034f141bebdabd3ed7e6118e9581ec4646707beaf8438f164ae51f382f2c1dR69-R77
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe caching the values like in the original PR is the right call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, listing all the Nodes and all the Pods clearly does not scale at all.
We need to reconsider re-activating / improving the cache, intersecting #588. That may provide a smooth transition once we migrate over to controller-runtime.
Otherwise, we can consider a simple caching mechanism, e.g. that would rate limit the call to
allocatableCapacityusing something likegolang.org/x/time/rate.NewLimiter.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made another commit to schedule the expensive call to run once a minute. I wasn't sure how to use
golang.org/x/time/rate.NewLimiterwithout making it look like an overkill.