Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MCAD logo #673

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Add MCAD logo #673

merged 3 commits into from
Oct 30, 2023

Conversation

mamy-CS
Copy link
Contributor

@mamy-CS mamy-CS commented Oct 27, 2023

What changes have been made

Adding MCAD logo

Verification steps

MCAD logo has been added under doc/images/mcad_logo.png

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Signed-off-by: Mohammed Abdi <[email protected]>
@asm582
Copy link
Member

asm582 commented Oct 27, 2023

Thanks @mamy-CS , do you think we can add this to the ReadME of the MCAD project?

@mamy-CS
Copy link
Contributor Author

mamy-CS commented Oct 30, 2023

Thanks @mamy-CS , do you think we can add this to the ReadME of the MCAD project?

Added!

@asm582
Copy link
Member

asm582 commented Oct 30, 2023

/LGTM

@asm582
Copy link
Member

asm582 commented Oct 30, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Oct 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asm582

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@asm582 asm582 merged commit 12e9903 into project-codeflare:main Oct 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants