Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aggregating roles for ns admin and editor #701

Closed

Conversation

KPostOffice
Copy link
Contributor

Issue link

https://issues.redhat.com/browse/RHOAIENG-2184

What changes have been made

Added a cluster roles which aggregate to admin and editor roles

Verification steps

Make sure unprivileged user can create AppWrappers in namespaces where they have editor or admin privileges

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot requested review from asm582 and dimakis January 25, 2024 17:03
Copy link

openshift-ci bot commented Jan 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sutaakar for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@KPostOffice
Copy link
Contributor Author

Disregard this PR for fixing the linked Jira issue. That change needs to happen in the CFO. This is still a worthwhile PR, just not high priority

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant