EncryptedStore: Fixed not throwing error in Swift #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• When an Objective-C method ends with a parameter that is a pointer to an error, it is imported to Swift as a method that throws. However, the error will only be thrown if the return value is either nil or false. All the public methods ending with an error pointer parameter were checked for this flaw. Only these three needed correction: + (NSPersistentStoreCoordinator *)coordinator:byAddingStoreAtURL:configuration:options:error: + (NSPersistentStoreCoordinator *)makeStoreWithOptions:managedObjectModel:error: + (NSPersistentStoreDescription *)makeDescriptionWithOptions:configuration:error:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• When an Objective-C method ends with a parameter that is a pointer to an error, it is imported to Swift as a method that throws. However, the error will only be thrown if the return value is either nil or false. All the public methods ending with an error pointer parameter were checked for this flaw. Only these three needed correction: