Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-5137] Initial managed summary tasks rework #5469

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

lcouzens
Copy link
Contributor

@lcouzens lcouzens commented Jan 28, 2025

Jira Ticket

COST-5137

Description

This change will move our ocp on cloud update summary tables logic to its own function and enable us to trigger it subtly differently for Manged tables vs Standard ingest flows.

Test 1

  1. Checkout Branch
  2. Restart Koku
  3. ingest data like normal (Old way)
  4. Everything should function correctly (no regressions)

Test 2

  1. Checkout Branch
  2. Restart Koku
  3. Enable the following unleash flags is_managed_ocp_cloud_processing_enabled and is_managed_ocp_cloud_summary_enabled
  4. Ingest ocp on cloud data.
  5. Currently should see an error message of managed_####### table does not exist (requires Cody's PR commit: c2bae58e470f03735d55071edc1e6a0ec2a0414d)
  6. With Cody's PR everything should be populated correctly

Release Notes

  • proposed release note
* [COST-5137](https://issues.redhat.com/browse/COST-5137) Adds new trigger for managed tables summary

@@ -583,77 +642,22 @@ def update_summary_tables( # noqa: C901
set_summary_timestamp(ManifestState.FAILED, manifest_id)
raise ex

if provider_type != Provider.PROVIDER_OCP:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

586 to 597 here is redundant code now that we always run cost model updates regardless of a cost model existing now. Also tweaking line 655 below should make this simpler.

@lcouzens lcouzens added the smoke-tests pr_check will build the image and run minimal required smokes label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant