Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for updateBotbar (see line 203 in Chart.svelte) #119

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vattevaii
Copy link

Well, I was building something with the library.. and ended up needing the drawBotBar method in my navy script..

Found it was not implemented.. Got ahead and read the code.. (well installed prettier for readability, inconsistent spacing all over the files)

Implemented it..

What i did:

  • added a grids array on Chart.svelte, binded it to the grid instance in Pane.svelte
  • pass the grids array into BotBar, extract all layers $: layers = grids.map((grid) => grid.getLayers() || []).flat()
  • call drawBotBar if present in each layer

Copy link

netlify bot commented May 1, 2024

Deploy Preview for shiny-selkie-5e063f canceled.

Name Link
🔨 Latest commit b9dec95
🔍 Latest deploy log https://app.netlify.com/sites/shiny-selkie-5e063f/deploys/668068a78bbd1d00081fa3e1

@vattevaii
Copy link
Author

if you need me to remove prettier, please do tell
or I could separate my commits into

  • prettier format whole project
  • then do the required changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant