Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESLint for Code Readability & Fix Various Issues (issue #30 and pr #97) #130

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

erdemozveren
Copy link

This PR adds ESLint to help with code readability and catch common syntax issues, I did my best for linter rules to not interfere with library logic. Also, it includes a couple of fixes that I encounter:

With these changes, the code should be a bit cleaner, and these bugs should be resolved!

Changes:

  • Added ESLint and set up the config.
  • Fixed small syntax issues spotted by ESLint.
  • Refactor the candle remaining time logic.
  • Commented out a line to fix the timezone issue with the bottom bar.

Testing:

  • ESLint runs without any errors.
  • Candle time and bottom bar are working fine now.
  • Run stack.execAll() and got no errors and everythings seems to be working (idk if its throw any but seems alright to me)

Hope this library doesn't die. I switched to this from TVJS, and it seems to be the best of both worlds.
Let me know if any adjustments are needed! 🚀

Copy link

netlify bot commented Feb 16, 2025

Deploy Preview for shiny-selkie-5e063f canceled.

Name Link
🔨 Latest commit ec4a35e
🔍 Latest deploy log https://app.netlify.com/sites/shiny-selkie-5e063f/deploys/67b163dbe8df4c00085128ef

@erdemozveren erdemozveren marked this pull request as draft February 16, 2025 04:13
@erdemozveren erdemozveren marked this pull request as ready for review February 16, 2025 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant