Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP CFFI Wrapper for routing table tools #7

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

mundya
Copy link
Member

@mundya mundya commented Jun 4, 2016

  • CFFI wrapper for m-Trie
  • CFFI wrapper for Ordered Covering
  • Utilities for converting to/from C format
  • Scripts to replace desktop/* executables
  • Travis updates
  • Ignore coverage on cffi_compile.py
  • Utilities for writing/reading routing table files
  • CFFI wrapper for remove_default_routes when merged
  • Ensure setup.py is correct
  • Update README
  • Add initial sort to OC implementation

For a later PR

  • SpiNNaker interface for routing table minimisation

@mundya
Copy link
Member Author

mundya commented Jun 4, 2016

@mossblaser any thoughts would be greatly appreciated :)

"License :: OSI Approved :: GNU General Public License v2 (GPLv2)",

"Operating System :: POSIX :: Linux",
"Operating System :: Microsoft :: Windows",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or not

@mundya
Copy link
Member Author

mundya commented Jun 4, 2016

OK - I've no idea what's going on with the Travis tests, could you have a glance @mossblaser? Sorry!

@mossblaser
Copy link
Member

I've no idea what's going on with the Travis tests, could you have a glance @mossblaser?

I've only looked at one of the travis logs but it seems that Rig is not being installed in the dest environment (I don't believe it is in requirements-test.txt). Could that be it?

@mundya
Copy link
Member Author

mundya commented Jun 6, 2016

It is in the setup.py though, isn't that usually sufficient?


# Build CFFI Interface
cffi_modules=["rig_routing_tables/cffi_compile.py:ffi"],
setup_requires=["cffi>=1.0.0", "rig>=1.0.0, <2.0.0"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! I believe setup_requires packages are only installed for the duration of setup.py while install_requires packages is used for 'normal' dependencies.

@mundya
Copy link
Member Author

mundya commented Jun 6, 2016

Ah! I believe setup_requires packages are only installed for the duration of setup.py while install_requires packages is used for 'normal' dependencies.

What a rookie mistake... thank you :)

 - [x] CFFI wrapper for m-Trie
 - [x] CFFI wrapper for Ordered Covering
 - [x] Utilities for converting to/from C format
 - [ ] Scripts to replace desktop/* executables
 - [ ] Travis updates
 - [ ] Ignore coverage on cffi_compile.py
 - [ ] Utilities for writing/reading routing table files
 - [ ] CFFI wrapper for remove_default_routes when merged

For a later PR
 - SpiNNaker interface for routing table minimisation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants