remove value::view() member function

project-tsurugi · Jan 28, 2025 · bf09221 · bf09221
1 parent 0c61a5e
commit bf09221
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 27 deletions.
diff --git a/src/jogasaki/data/value.cpp b/src/jogasaki/data/value.cpp
@@ -38,25 +38,4 @@ std::size_t value::type_index() const noexcept {
     return body_.index();
 }
 
-any value::view() const {
-    switch(type_index()) {
-        case index<std::monostate>: return any{};
-        case index<std::int8_t>: return any{std::in_place_type<std::int8_t>, ref<std::int8_t>()};
-        case index<std::int16_t>: return any{std::in_place_type<std::int16_t>, ref<std::int16_t>()};
-        case index<std::int32_t>: return any{std::in_place_type<std::int32_t>, ref<std::int32_t>()};
-        case index<std::int64_t>: return any{std::in_place_type<std::int64_t>, ref<std::int64_t>()};
-        case index<float>: return any{std::in_place_type<float>, ref<float>()};
-        case index<double>: return any{std::in_place_type<double>, ref<double>()};
-        case index<std::string>: return any{std::in_place_type<accessor::text>, accessor::text{ref<std::string>()}};
-        case index<binary_string_value>: return any{std::in_place_type<accessor::binary>, accessor::binary{ref<binary_string_value>().str()}};
-        case index<runtime_t<meta::field_type_kind::decimal>>: return any{std::in_place_type<runtime_t<meta::field_type_kind::decimal>>, ref<runtime_t<meta::field_type_kind::decimal>>()};
-        case index<runtime_t<meta::field_type_kind::date>>: return any{std::in_place_type<runtime_t<meta::field_type_kind::date>>, ref<runtime_t<meta::field_type_kind::date>>()};
-        case index<runtime_t<meta::field_type_kind::time_of_day>>: return any{std::in_place_type<runtime_t<meta::field_type_kind::time_of_day>>, ref<runtime_t<meta::field_type_kind::time_of_day>>()};
-        case index<runtime_t<meta::field_type_kind::time_point>>: return any{std::in_place_type<runtime_t<meta::field_type_kind::time_point>>, ref<runtime_t<meta::field_type_kind::time_point>>()};
-        case index<std::size_t>: return any{std::in_place_type<std::size_t>, ref<std::size_t>()};
-        default: fail_with_exception();
-    }
-    std::abort();
-}
-
 }  // namespace jogasaki::data
diff --git a/src/jogasaki/data/value.h b/src/jogasaki/data/value.h
@@ -98,11 +98,6 @@ class value {
      */
     [[nodiscard]] std::size_t type_index() const noexcept;
 
-    /**
-     * @brief return the any class as the view of this object
-     */
-    [[nodiscard]] any view() const;
-
     // variant index in value - treat bool as std::int8_t
     template <class T>
     static constexpr std::size_t index =

diff --git a/test/jogasaki/data/value_test.cpp b/test/jogasaki/data/value_test.cpp
@@ -40,6 +40,7 @@
 #include <jogasaki/data/value.h>
 #include <jogasaki/test_root.h>
 #include <jogasaki/test_utils.h>
+#include <jogasaki/utils/value_to_any.h>
 
 namespace jogasaki::executor::expr {
 
@@ -136,7 +137,8 @@ TEST_F(value_test, string) {
     ASSERT_FALSE(v.empty());
     ASSERT_EQ("ABC", v.ref<std::string>());
 
-    auto a = v.view();
+    data::any a{};
+    ASSERT_TRUE(utils::value_to_any(v, a));
     auto t = a.to<accessor::text>();
     // static_cast to sv requires accessor::text lvalue as sv can reference SSO'ed data in accessor::text.
     auto sv = static_cast<std::string_view>(t);