fix: added 'httpGet.scheme' to chart values, so (#8)

it could be adjusted if TLS is enabled in configuration. Further clarified the use of 'authHeader' value. Signed-off-by: [email protected] Signed-off-by: masoudbahar <[email protected]>
project-zot · Jul 4, 2023 · 247ebb2 · 247ebb2
1 parent 00f0493
commit 247ebb2
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 5 deletions.
diff --git a/charts/zot/Chart.yaml b/charts/zot/Chart.yaml
@@ -3,4 +3,4 @@ appVersion: v2.0.0-rc5
 description: A Helm chart for Kubernetes
 name: zot
 type: application
-version: 0.1.24
+version: 0.1.25
diff --git a/charts/zot/templates/deployment.yaml b/charts/zot/templates/deployment.yaml
@@ -55,6 +55,7 @@ spec:
             httpGet:
               path: /v2/
               port: 5000
+              scheme: {{ .Values.httpGet.scheme }}
               {{- if .Values.authHeader }}
               httpHeaders:
                 - name: Authorization
@@ -65,6 +66,7 @@ spec:
             httpGet:
               path: /v2/
               port: 5000
+              scheme: {{ .Values.httpGet.scheme }}
               {{- if .Values.authHeader }}
               httpHeaders:
                 - name: Authorization

diff --git a/charts/zot/values.yaml b/charts/zot/values.yaml
@@ -39,6 +39,12 @@ ingress:
   #  - secretName: chart-example-tls
   #    hosts:
   #      - chart-example.local
+
+# By default, Kubernetes HTTP probes use HTTP 'scheme'. So if TLS is enabled
+# in configuration, to prevent failures, the scheme must be set to 'HTTPS'.
+httpGet:
+  scheme: HTTP
+
 # If mountConfig is true the configMap named $CHART_RELEASE-config is mounted
 # on the pod's '/etc/zot' directory
 mountConfig: false
@@ -89,10 +95,11 @@ secretFiles:
   htpasswd: |-
     admin:$2y$05$vmiurPmJvHylk78HHFWuruFFVePlit9rZWGA/FbZfTEmNRneGJtha
     user:$2y$05$L86zqQDfH5y445dcMlwu6uHv.oXFgT6AiJCwpv3ehr7idc0rI3S2G
-# Authentication string for tests, it contains a `user:password` string encoded
-# in base64. It is needed when `htpasswd` authentication is enabled and the
-# default access does not provide read permission
-# The example value is from running `echo -n "foo:var" | base64`
+
+# Authentication string for Kubernetes probes, which is needed when `htpasswd`
+# authentication is enabled, but the anonymous access policy is not.
+# It contains a `user:password` string encoded in base64. The example value is
+# from running `echo -n "foo:var" | base64`
 # authHeader: "Zm9vOmJhcg=="
 
 # If persistence is 'true' the service uses a persistentVolumeClaim to mount a