fix: swagger Makefile target broken on darwin #1701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adodon2go
requested review from
rchincha,
andaaron and
eusebiu-constantin-petu-dbk
as code owners
|
@adodon2go can u pls check the build failure? |
adodon2go
force-pushed
the
darwin-swagger
branch
from
54de46a
to
7701364
Compare
Codecov Report
@@ Coverage Diff @@
## main #1701 +/- ##
==========================================
- Coverage 91.45% 91.44% -0.02%
==========================================
Files 123 123
Lines 25990 25990
==========================================
- Hits 23770 23767 -3
- Misses 1654 1656 +2
- Partials 566 567 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Alexei Dodon <[email protected]>
adodon2go
force-pushed
the
darwin-swagger
branch
from
7701364
to
c70b8c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug
Which issue does this PR fix:
What does this PR do / Why do we need it:
On Mac OS the swagger target does nothing (because of using . or DOT in makefile target name)
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
No
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.