Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tests): Migrate some of the older tests to the new image-utils library #1863

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

andaaron
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@andaaron andaaron marked this pull request as ready for review September 27, 2023 19:55
@andaaron andaaron force-pushed the test-4 branch 2 times, most recently from a01ab57 to 08f0a5f Compare October 2, 2023 12:27
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #1863 (39783da) into main (2fd7bfc) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1863      +/-   ##
==========================================
- Coverage   92.04%   92.00%   -0.05%     
==========================================
  Files         152      152              
  Lines       26455    26378      -77     
==========================================
- Hits        24350    24268      -82     
- Misses       1555     1559       +4     
- Partials      550      551       +1     
Files Coverage Δ
pkg/compliance/v1_0_0/check.go 99.01% <100.00%> (-0.09%) ⬇️
pkg/test/image-utils/multiarch.go 93.02% <100.00%> (+0.08%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andaaron andaaron force-pushed the test-4 branch 2 times, most recently from 87aab85 to 42a7294 Compare October 2, 2023 13:11
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha rchincha merged commit 99e29c0 into project-zot:main Oct 2, 2023
32 of 33 checks passed
@andaaron andaaron self-assigned this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants