fix: metrics endpoint must be secured behind authN #1864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1864 +/- ##
==========================================
+ Coverage 92.02% 92.04% +0.01%
==========================================
Files 152 152
Lines 26454 26455 +1
==========================================
+ Hits 24344 24350 +6
+ Misses 1559 1555 -4
+ Partials 551 550 -1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
adodon2go
force-pushed
the
secure-metrics-endpoint
branch
2 times, most recently
from
a2be177
to
6805636
Compare
adodon2go
requested review from
rchincha,
andaaron and
eusebiu-constantin-petu-dbk
as code owners
eusebiu-constantin-petu-dbk
previously approved these changes
Sep 29, 2023
rchincha
reviewed
Sep 29, 2023
adodon2go
force-pushed
the
secure-metrics-endpoint
branch
3 times, most recently
from
e44b4f5
to
f524b42
Compare
andaaron
reviewed
Sep 30, 2023
Signed-off-by: Alexei Dodon <[email protected]>
adodon2go
force-pushed
the
secure-metrics-endpoint
branch
from
f524b42
to
c32bbfc
Compare
andaaron
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug
Which issue does this PR fix:
#1859
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.