Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add more tests for GCing indexes referencing other indexes referencing manifests #2716

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

andaaron
Copy link
Contributor

Looks like we didn't have many GC tests for retaining multiarch images. I added more data to the existing image retention tests, besides the new GC tests.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…rencing manifests

Looks like we didn't have many GC tests for retaining multiarch images.
I added more data to the existing image retention tests, besides the new GC tests.

Signed-off-by: Andrei Aaron <[email protected]>
@andaaron andaaron marked this pull request as ready for review October 11, 2024 17:00
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.72%. Comparing base (c89be3a) to head (62e7d0e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2716      +/-   ##
==========================================
+ Coverage   92.70%   92.72%   +0.01%     
==========================================
  Files         169      169              
  Lines       22552    22557       +5     
==========================================
+ Hits        20907    20916       +9     
+ Misses       1026     1024       -2     
+ Partials      619      617       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andaaron andaaron merged commit a10c5fa into project-zot:main Oct 11, 2024
39 checks passed
@andaaron andaaron deleted the gc2 branch October 11, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants