fix: max wait time on dynamodb #2730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2730 +/- ##
==========================================
- Coverage 92.72% 92.12% -0.61%
==========================================
Files 169 169
Lines 22563 30017 +7454
==========================================
+ Hits 20922 27652 +6730
- Misses 1024 1748 +724
Partials 617 617 ☔ View full report in Codecov by Sentry. |
|
@vanhtuan0409 under what conditions are you seeing this failure? |
|
@rchincha on fresh start. When zot need to create dynamodb table. During the creation process, zot wait for dynamodb table to be created |
|
Hi @vanhtuan0409, please amend the commit to both gpg sign and signoff. Otherwise looks good. |
Signed-off-by: Tuan Vuong <[email protected]>
vanhtuan0409
force-pushed
the
fix-wait-table
branch
from
dc16f5a
to
122fa0a
Compare
|
@andaaron force pushed with signoff and signature |
andaaron
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug fix
Which issue does this PR fix:
Fix zot unable to create dynamodb table. Upon starting zot with
cacheDriverconfigured to dynamodb. Zot will panic with errorexceeded max wait time for TableExists waiter.Dynamodb table is successfully created but not seeded with Zot version
What does this PR do / Why do we need it:
Zot was unable to wait for dynamodb table to be created. This was due to
maxWaitTimeset too low. More to be reference on AWS SDK issue aws/aws-sdk-go-v2#2551Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
no
Does this PR introduce any user-facing change?:
no
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.