Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: less confusing warning message when unexpected media type is found in index manifest list #2746

Merged
merged 1 commit into from
Oct 25, 2024
Merged

chore: less confusing warning message when unexpected media type is found in index manifest list #2746

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/storage/common/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,9 +549,10 @@ func IsBlobReferencedInImageIndex(imgStore storageTypes.ImageStore, repo string,
case ispec.MediaTypeImageManifest:
found, _ = isBlobReferencedInImageManifest(imgStore, repo, digest, desc.Digest, log)
default:
log.Warn().Str("mediatype", desc.MediaType).Msg("unknown media-type")
// should return true for digests found in index.json even if we don't know it's mediatype
if digest == desc.Digest {
log.Debug().Str("mediatype", desc.MediaType).Str("digest", digest.String()).
Msg("unexpected media-type found in image index manifest list")
found = true
}
}
Expand Down
Loading