Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update go tests to use our hosted trivy-db and trivy-java-db images #2754

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

andaaron
Copy link
Contributor

@andaaron andaaron commented Nov 1, 2024

This is to avoid errors such as:

Error: failed to resolve latest: GET "https://ghcr.io/v2/aquasecurity/trivy-db/manifests/latest": response status code 429: toomanyrequests: retry-after: 338.733µs, allowed: 44000/minute

or

Error: GET "https://ghcr.io/v2/aquasecurity/trivy-java-db/blobs/sha256:44136fa355b3678a1146ad16f7e8649e94fb4fc21fe77e8310c060f61caaff8a": response status code 429: toomanyrequests: retry-after: 271.886µs, allowed: 44000/minute

There are 2 remaining exceptions that I am aware of:

  1. The tests under test/blackbox/cve.bats
  2. One of the cli tests checking the server attempts download of the databases from the default url

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…mages

There are 2 remaining exceptions that I am aware of:
1. The tests under test/blackbox/cve.bats
2. One of the cli tests checking the server attempts download of the databases
from the default url

Signed-off-by: Andrei Aaron <[email protected]>
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.93%. Comparing base (30ecced) to head (2e1104d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2754   +/-   ##
=======================================
  Coverage   91.93%   91.93%           
=======================================
  Files         170      170           
  Lines       30121    30121           
=======================================
  Hits        27692    27692           
  Misses       1806     1806           
  Partials      623      623           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andaaron andaaron marked this pull request as ready for review November 1, 2024 12:24
Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha rchincha merged commit da923ae into project-zot:main Nov 1, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants