feat(cve): add more information #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andreea-Lupu <[email protected]>
Andreea-Lupu
force-pushed
the
cve_add_more_details
branch
from
e1ab726
to
7aa0ad8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #419 +/- ##
==========================================
+ Coverage 88.60% 88.77% +0.17%
==========================================
Files 56 56
Lines 1720 1720
Branches 451 463 +12
==========================================
+ Hits 1524 1527 +3
+ Misses 185 182 -3
Partials 11 11 ☔ View full report in Codecov by Sentry. |
|
The change looks good. I do have some suggestions for improvements:
What we have right now is functional and visibly and improvement for the user, but I have a concern with regards to how it will behave for a large number of images to be scanned. |
andaaron
added a commit
to andaaron/zot
that referenced
this pull request
Feb 5, 2024
see: project-zot/zui#419 Signed-off-by: Andrei Aaron <[email protected]>
rchincha
pushed a commit
to project-zot/zot
that referenced
this pull request
Feb 5, 2024
see: project-zot/zui#419 Signed-off-by: Andrei Aaron <[email protected]>
This was referenced Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix:
#405
#394
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Does this change require updates to the CNI daemonset config files to work?:
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.