[8.x] Add blacklight-frontend pin to importmap #3502
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's too close to the end of the day to undraft, but curious if this seems useful.
I think #3371 was a good idea. Blacklight Gallery is already using
blacklight-frontendto import Blacklight. We noticed that in the Spotlight test app, the blacklight-gallery JavaScript stopped loading in the importmap only build. One of the reasons is theblacklight->blacklight-frontendrename isn't in an 8.x release, so that importmap doesn't exist.I think it could be useful to provide an entry point with that name in 8.x so that other code can
without having to worry too much about what version of Blacklight is being used.