Prevent LoadBalancer updates on follower. #6872
Draft
+44
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsaarni
requested review from
skriss and
sunjayBhatia
and removed request for
a team
sunjayBhatia
requested review from
a team,
davinci26 and
izturn
and removed request for
a team
Follower instances of Contour do not run loadBalancerStatusWriter and therefore do not read from the channel that receives status updates. The LoadBalancer status updates are still watched and sent to a channel, causing the go routine to block. This led to LoadBalancer updates piling up and consuming memory, eventually causing an out-of-memory condition and killing the Contour process. Signed-off-by: Tero Saarni <[email protected]>
tsaarni
force-pushed
the
lbstatus-on-follower
branch
from
8b2af7d to
920d0ce
Compare
tsaarni
added
the
release-note/small
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6872 +/- ##
==========================================
- Coverage 81.05% 81.04% -0.02%
==========================================
Files 133 133
Lines 20026 20034 +8
==========================================
+ Hits 16232 16236 +4
- Misses 3500 3504 +4
Partials 294 294
|
Levi080513
reviewed
Jan 21, 2025
| func (s *ServiceStatusLoadBalancerWatcher) notify(lbstatus core_v1.LoadBalancerStatus) { | ||
| s.LBStatus <- lbstatus | ||
| if s.leader.Load() { |
There was a problem hiding this comment.
Is it possible to lose the envoy service event in this way?
There was a problem hiding this comment.
True. Currently the event processing logic relies on Added/Updated/Deleted events alone. It works for other resource types as they will be processed by all Contour instances but I think new approach is needed with the load balancer status updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a memory leak that was triggered by LoadBalancer status updates. Only the leader instance runs
loadBalancerStatusWriterand therefore follower does not have anyone reading from the channel that receives status updates. The LoadBalancer status updates are still watched by followers and sent to the channel, causing the go routine callingServiceStatusLoadBalancerWatcher.notify()to block. This led toLoadBalancerStatusupdates piling up and consuming memory, eventually causing an out-of-memory condition and killing the Contour process.Fixes #6860