make resources var consistent

pkg/providers/aws/aws.go

@@ -196,7 +196,7 @@ func worker(ctx context.Context, fn getResourcesFunc, ch chan<- result) {
 }
 
 func (p *Provider) Resources(ctx context.Context) (*schema.Resources, error) {
-	finalList := schema.NewResources()
+	finalResources := schema.NewResources()
 
 	var workersWaitGroup sync.WaitGroup
 	results := make(chan result)
@@ -262,7 +262,7 @@ func (p *Provider) Resources(ctx context.Context) (*schema.Resources, error) {
 		if result.err != nil {
 			continue
 		}
-		finalList.Merge(result.resources)
+		finalResources.Merge(result.resources)
 	}
-	return finalList, nil
+	return finalResources, nil
 }

pkg/providers/consul/consul.go

@@ -121,10 +121,10 @@ const (
 
 // Resources returns the provider for an resource deployment source.
 func (p *Provider) Resources(ctx context.Context) (*schema.Resources, error) {
-	finalList := schema.NewResources()
+	finalResources := schema.NewResources()
 	provider := &resourceProvider{client: p.client, id: p.id}
 	if resources, err := provider.GetResource(ctx); err == nil {
-		finalList.Merge(resources)
+		finalResources.Merge(resources)
 	}
-	return finalList, nil
+	return finalResources, nil
 }

pkg/providers/digitalocean/digitalocean.go

@@ -66,15 +66,15 @@ const apiKey = "digitalocean_token"
 
 // Resources returns the provider for an resource deployment source.
 func (p *Provider) Resources(ctx context.Context) (*schema.Resources, error) {
-	finalList := schema.NewResources()
+	finalResources := schema.NewResources()
 
 	if p.services.Has("droplet") || p.services.Has("instance") {
 		instanceprovider := &instanceProvider{client: p.client, id: p.id}
 		instances, err := instanceprovider.GetResource(ctx)
 		if err != nil {
 			return nil, err
 		}
-		finalList.Merge(instances)
+		finalResources.Merge(instances)
 	}
 
 	if p.services.Has("app") {
@@ -83,8 +83,8 @@ func (p *Provider) Resources(ctx context.Context) (*schema.Resources, error) {
 		if err != nil {
 			return nil, err
 		}
-		finalList.Merge(apps)
+		finalResources.Merge(apps)
 	}
 
-	return finalList, nil
+	return finalResources, nil
 }

pkg/providers/gcp/gcp.go

@@ -145,15 +145,15 @@ func New(options schema.OptionBlock) (*Provider, error) {
 
 // Resources returns the provider for an resource deployment source.
 func (p *Provider) Resources(ctx context.Context) (*schema.Resources, error) {
-	finalList := schema.NewResources()
+	finalResources := schema.NewResources()
 
 	if p.dns != nil {
 		cloudDNSProvider := &cloudDNSProvider{dns: p.dns, id: p.id, projects: p.projects}
 		zones, err := cloudDNSProvider.GetResource(ctx)
 		if err != nil {
 			return nil, err
 		}
-		finalList.Merge(zones)
+		finalResources.Merge(zones)
 	}
 
 	if p.gke != nil {
@@ -162,7 +162,7 @@ func (p *Provider) Resources(ctx context.Context) (*schema.Resources, error) {
 		if err != nil {
 			gologger.Warning().Msgf("Could not get GKE resources: %s\n", err)
 		}
-		finalList.Merge(gkeData)
+		finalResources.Merge(gkeData)
 	}
 
 	if p.compute != nil {
@@ -171,7 +171,7 @@ func (p *Provider) Resources(ctx context.Context) (*schema.Resources, error) {
 		if err != nil {
 			return nil, err
 		}
-		finalList.Merge(vmData)
+		finalResources.Merge(vmData)
 	}
 
 	if p.storage != nil {
@@ -180,7 +180,7 @@ func (p *Provider) Resources(ctx context.Context) (*schema.Resources, error) {
 		if err != nil {
 			return nil, err
 		}
-		finalList.Merge(storageData)
+		finalResources.Merge(storageData)
 	}
 
 	if p.functions != nil {
@@ -189,7 +189,7 @@ func (p *Provider) Resources(ctx context.Context) (*schema.Resources, error) {
 		if err != nil {
 			return nil, err
 		}
-		finalList.Merge(functionsData)
+		finalResources.Merge(functionsData)
 	}
 
 	if p.run != nil {
@@ -198,8 +198,8 @@ func (p *Provider) Resources(ctx context.Context) (*schema.Resources, error) {
 		if err != nil {
 			return nil, err
 		}
-		finalList.Merge(cloudRunData)
+		finalResources.Merge(cloudRunData)
 	}
 
-	return finalList, nil
+	return finalResources, nil
 }