Fixed nil fields being dereferenced for public ips #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove items moved to the centralized docs * Update links --------- Co-authored-by: Brendan O'Leary <[email protected]>
ehsandeep
requested changes
May 4, 2024
|
@ehsandeep let me know if those changes look good for you. |
Ice3man543
requested changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When iterating through some VMs, the PublicIPAddress field on the ipConfig struct can be nil. In these cases, we don't want to dereference and just want to go to the next configuration.
Also, the IPAddress for a nic IP could also be nil and in the same case, we do not want to dereference and add to the list. We'd rather leave it off.