Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix DSL filter and matcher #1313

Merged
merged 1 commit into from
Aug 9, 2023
Merged

fix DSL filter and matcher #1313

merged 1 commit into from
Aug 9, 2023

Conversation

dogancanbakir
Copy link
Member

This PR fixes DSL-based filter and matcher. Closes #1283.

$ go run . -u https://jsdk.baidu.com -fdc "contains(body_md5, '595e88012a6521aae3e12cbebe76eb9e')" -json

    __    __  __       _  __
   / /_  / /_/ /_____ | |/ /
  / __ \/ __/ __/ __ \|   /
 / / / / /_/ /_/ /_/ /   |
/_/ /_/\__/\__/ .___/_/|_|
             /_/

                projectdiscovery.io

[INF] Current httpx version v1.3.4 (latest)

@dogancanbakir dogancanbakir self-assigned this Aug 4, 2023
@dogancanbakir dogancanbakir linked an issue Aug 4, 2023 that may be closed by this pull request
@RamanaReddy0M
Copy link
Contributor

@dogancanbakir it seems working in version 1.3.4!

httpx git:(dev) ✗ go run . -u https://jsdk.baidu.com -fdc "contains(body_md5, '595e88012a6521aae3e12cbebe76eb9e')"


    __    __  __       _  __
   / /_  / /_/ /_____ | |/ /
  / __ \/ __/ __/ __ \|   /
 / / / / /_/ /_/ /_/ /   |
/_/ /_/\__/\__/ .___/_/|_|
             /_/

                projectdiscovery.io

[INF] Current httpx version v1.3.4 (latest)
https://jsdk.baidu.com

@dogancanbakir
Copy link
Member Author

@RamanaReddy0M, The result is not being filtered out properly. If the DSL expression matches with the result, the output should be empty.

Copy link
Contributor

@RamanaReddy0M RamanaReddy0M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

✗ go run . -u https://jsdk.baidu.com -fdc "contains(body_md5, '595e88012a6521aae3e12cbebe76eb9e')" -hash md5

    __    __  __       _  __
   / /_  / /_/ /_____ | |/ /
  / __ \/ __/ __/ __ \|   /
 / / / / /_/ /_/ /_/ /   |
/_/ /_/\__/\__/ .___/_/|_|
             /_/

                projectdiscovery.io

[INF] Current httpx version v1.3.4 (latest)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

body_md5 in filter-condition not work
3 participants