Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix screenshot path issue #1340

Merged
merged 1 commit into from
Sep 7, 2023
Merged

fix screenshot path issue #1340

merged 1 commit into from
Sep 7, 2023

Conversation

dogancanbakir
Copy link
Member

@dogancanbakir dogancanbakir commented Aug 31, 2023 •
edited by RamanaReddy0M
Loading

Closes #1328.

before:

$ go run . -u projectdiscovery.io -screenshot

    __    __  __       _  __
   / /_  / /_/ /_____ | |/ /
  / __ \/ __/ __/ __ \|   /
 / / / / /_/ /_/ /_/ /   |
/_/ /_/\__/\__/ .___/_/|_|
             /_/

                projectdiscovery.io

[INF] Current httpx version v1.3.4 (latest)
https://scanme.sh

screenshot:
image

after:

$ go run . -u projectdiscovery.io -screenshot

    __    __  __       _  __
   / /_  / /_/ /_____ | |/ /
  / __ \/ __/ __/ __ \|   /
 / / / / /_/ /_/ /_/ /   |
/_/ /_/\__/\__/ .___/_/|_|
             /_/

                projectdiscovery.io

[INF] Current httpx version v1.3.4 (latest)
https://scanme.sh

screenshot:
image

P.S. To simulate the WSL case, I ran httpx on Guest-OS (Debian, Docker) and opened the screenshot.html in the Host-OS(Darwin).

@dogancanbakir dogancanbakir linked an issue Aug 31, 2023 that may be closed by this pull request
HTTPX sets wrong path on WSL in screenshot function #1328
Closed
RamanaReddy0M
RamanaReddy0M approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@RamanaReddy0M RamanaReddy0M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ehsandeep ehsandeep merged commit e9893a8 into dev Sep 7, 2023
11 checks passed
@ehsandeep ehsandeep deleted the fix_screenshot_path_issue branch September 7, 2023 09:20
@chenrui333 chenrui333 mentioned this pull request Sep 14, 2023
Merged
@ppb007 ppb007 mentioned this pull request Sep 15, 2023
Closed
@ppb007 ppb007 mentioned this pull request Oct 31, 2023
Closed
@ppb007 ppb007 mentioned this pull request Nov 13, 2023
Closed
@ppb007 ppb007 mentioned this pull request Jan 16, 2024
Closed
@ppb007 ppb007 mentioned this pull request Jan 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@RamanaReddy0M RamanaReddy0M Awaiting requested review from RamanaReddy0M

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTTPX sets wrong path on WSL in screenshot function
3 participants
@dogancanbakir @ehsandeep @RamanaReddy0M