fix: no records behavior #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mzack9999 I've seen a new release 2 days ago. |
Mzack9999
approved these changes
Oct 14, 2024
gnuletik
force-pushed
the
fix/behavior-no-records
branch
from
e58d8da
to
6973421
Compare
|
@Mzack9999 I've updated the failing test to match with the error wrapping edit you made. Thanks! |
|
@ehsandeep @Mzack9999 can we merge this for the next release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #222 included in release https://github.com/projectdiscovery/retryabledns/releases/tag/v1.0.75 introduced a breaking change:
When no record are found, the error
ErrRetriesExceededis returned instead of an empty response.This PR restore the previous behavior.